From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix a bug --pcd option enable and use the pcd in expression
Date: Thu, 18 Oct 2018 01:04:01 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E33CF36@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1539736541-5448-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Wednesday, October 17, 2018 8:36 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Fix a bug --pcd option enable and use the
>pcd in expression
>
>the case is:
>in the DSC:
>[PcdsFixedAtBuild.common]
> TokenSpaceGuid.TestFixedPcd|0xFFEAA000
>
>[PcdsDynamicExDefault.common.DEFAULT]
>!if TokenSpaceGuid.PcdFlag == TRUE
>TokenSpaceGuid.PcdTest|TokenSpaceGuid.TestFixedPcd
>!endif
>
>Then build with --pcd TokenSpaceGuid.PcdFlag=TRUE, it report failure,
>but if we build without this --pcd option, it could build success.
>we found when the --pcd is enabled, the fixedatbuild pcds are not be
>collected into expression to calculate.
>
>Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1256
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/Workspace/DscBuildData.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py
>b/BaseTools/Source/Python/Workspace/DscBuildData.py
>index f41038e..ace348b 100644
>--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
>+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
>@@ -2942,6 +2942,7 @@ class DscBuildData(PlatformBuildClassObject):
> if ModuleFile in self._Modules:
> continue
> ModuleData = self._Bdb[ModuleFile, self._Arch, self._Target,
>self._Toolchain]
> PkgSet.update(ModuleData.Packages)
> self._DecPcds, self._GuidDict = GetDeclaredPcd(self, self._Bdb,
>self._Arch, self._Target, self._Toolchain, PkgSet)
>+ self._GuidDict.update(GlobalData.gPlatformPcds)
> return self._DecPcds
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-10-18 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 0:35 [Patch] BaseTools: Fix a bug --pcd option enable and use the pcd in expression Yonghong Zhu
2018-10-18 1:04 ` Gao, Liming [this message]
2018-10-18 14:18 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E33CF36@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox