From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3B6AA21167473 for ; Fri, 19 Oct 2018 07:43:51 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Oct 2018 07:43:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,400,1534834800"; d="scan'208";a="93362548" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 19 Oct 2018 07:43:50 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 Oct 2018 07:43:50 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 Oct 2018 07:43:50 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.21]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.224]) with mapi id 14.03.0319.002; Fri, 19 Oct 2018 22:43:48 +0800 From: "Gao, Liming" To: "Feng, Bob C" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool. Thread-Index: AQHUZqWCBpYCzVRn9E+zNQRk5BjtvaUmpvOQ Date: Fri, 19 Oct 2018 14:43:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3482D4@SHSMSX104.ccr.corp.intel.com> References: <20181018054319.20236-1-bob.c.feng@intel.com> In-Reply-To: <20181018054319.20236-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTY5YjljYmMtNGU0OS00NTI3LTk5NjQtZmE0N2Q1NzI2MmM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZklLSCtGUmpCT3dtcGFiWWxqaTJTK05KWStsK0FKMGsxelQ1NHU0UzdQT0RoS2JLM0MxSGt0cFwvRklnUzBlWU0ifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2018 14:43:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Bo= bCF > Sent: Thursday, October 18, 2018 1:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: Remove Arch specific build options for= PcdValueInit tool. >=20 > PcdValueInit tool is Arch independent, the Arch specific > build options should be removed from PcdValueInit makefile. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob C Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTool= s/Source/Python/Workspace/DscBuildData.py > index 19ac71ac09..47f5033953 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -2344,11 +2344,11 @@ class DscBuildData(PlatformBuildClassObject): > if Tool !=3D 'CC': > continue >=20 > if Target =3D=3D "*" or Target =3D=3D self._Target: > if Tag =3D=3D "*" or Tag =3D=3D self._Toolchain: > - if Arch =3D=3D "*" or Arch =3D=3D self.Arch: > + if Arch =3D=3D "*": > if Tool not in BuildOptions: > BuildOptions[Tool] =3D OrderedDict() > if Attr !=3D "FLAGS" or Attr not in BuildOptions= [Tool] or self.BuildOptions[Options].startswith('=3D'): > BuildOptions[Tool][Attr] =3D self.BuildOptio= ns[Options] > else: > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel