* [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.
@ 2018-10-18 5:43 BobCF
2018-10-18 14:17 ` Carsey, Jaben
2018-10-19 14:43 ` Gao, Liming
0 siblings, 2 replies; 3+ messages in thread
From: BobCF @ 2018-10-18 5:43 UTC (permalink / raw)
To: edk2-devel; +Cc: Bob C Feng, Liming Gao
PcdValueInit tool is Arch independent, the Arch specific
build options should be removed from PcdValueInit makefile.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob C Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 19ac71ac09..47f5033953 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -2344,11 +2344,11 @@ class DscBuildData(PlatformBuildClassObject):
if Tool != 'CC':
continue
if Target == "*" or Target == self._Target:
if Tag == "*" or Tag == self._Toolchain:
- if Arch == "*" or Arch == self.Arch:
+ if Arch == "*":
if Tool not in BuildOptions:
BuildOptions[Tool] = OrderedDict()
if Attr != "FLAGS" or Attr not in BuildOptions[Tool] or self.BuildOptions[Options].startswith('='):
BuildOptions[Tool][Attr] = self.BuildOptions[Options]
else:
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.
2018-10-18 5:43 [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool BobCF
@ 2018-10-18 14:17 ` Carsey, Jaben
2018-10-19 14:43 ` Gao, Liming
1 sibling, 0 replies; 3+ messages in thread
From: Carsey, Jaben @ 2018-10-18 14:17 UTC (permalink / raw)
To: Feng, Bob C, edk2-devel@lists.01.org; +Cc: Gao, Liming
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> BobCF
> Sent: Wednesday, October 17, 2018 10:43 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] BaseTools: Remove Arch specific build options for
> PcdValueInit tool.
>
> PcdValueInit tool is Arch independent, the Arch specific
> build options should be removed from PcdValueInit makefile.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob C Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py
> b/BaseTools/Source/Python/Workspace/DscBuildData.py
> index 19ac71ac09..47f5033953 100644
> --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> @@ -2344,11 +2344,11 @@ class DscBuildData(PlatformBuildClassObject):
> if Tool != 'CC':
> continue
>
> if Target == "*" or Target == self._Target:
> if Tag == "*" or Tag == self._Toolchain:
> - if Arch == "*" or Arch == self.Arch:
> + if Arch == "*":
> if Tool not in BuildOptions:
> BuildOptions[Tool] = OrderedDict()
> if Attr != "FLAGS" or Attr not in BuildOptions[Tool] or
> self.BuildOptions[Options].startswith('='):
> BuildOptions[Tool][Attr] = self.BuildOptions[Options]
> else:
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.
2018-10-18 5:43 [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool BobCF
2018-10-18 14:17 ` Carsey, Jaben
@ 2018-10-19 14:43 ` Gao, Liming
1 sibling, 0 replies; 3+ messages in thread
From: Gao, Liming @ 2018-10-19 14:43 UTC (permalink / raw)
To: Feng, Bob C, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of BobCF
> Sent: Thursday, October 18, 2018 1:43 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.
>
> PcdValueInit tool is Arch independent, the Arch specific
> build options should be removed from PcdValueInit makefile.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob C Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
> index 19ac71ac09..47f5033953 100644
> --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> @@ -2344,11 +2344,11 @@ class DscBuildData(PlatformBuildClassObject):
> if Tool != 'CC':
> continue
>
> if Target == "*" or Target == self._Target:
> if Tag == "*" or Tag == self._Toolchain:
> - if Arch == "*" or Arch == self.Arch:
> + if Arch == "*":
> if Tool not in BuildOptions:
> BuildOptions[Tool] = OrderedDict()
> if Attr != "FLAGS" or Attr not in BuildOptions[Tool] or self.BuildOptions[Options].startswith('='):
> BuildOptions[Tool][Attr] = self.BuildOptions[Options]
> else:
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-19 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-18 5:43 [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool BobCF
2018-10-18 14:17 ` Carsey, Jaben
2018-10-19 14:43 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox