public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg
Date: Mon, 22 Oct 2018 15:07:46 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E34CE2E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E33CBF7@SHSMSX104.ccr.corp.intel.com>

Ard, Leif and Mike:
  Have you any comments on this change? This patch updates all platform DSC/FDF in edk2-platform master to refer to FatPkg instead of FatBinPkg, because we will remove FatBinPkg. 

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao, Liming
> Sent: Wednesday, October 17, 2018 9:11 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg
> 
> Ard:
>   Do you know who can review this patch?
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of shenglei
> > Sent: Tuesday, October 16, 2018 11:43 AM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg
> >
> > In order to remove FatBinPkg, relationships depend on
> > FatBinPkg need to be replaced by FatPkg in fdf. And
> > FatPkg needs to be added in dsc.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  Platform/ARM/JunoPkg/ArmJuno.dsc                     | 1 +
> >  Platform/ARM/JunoPkg/ArmJuno.fdf                     | 2 +-
> >  Platform/ARM/SgiPkg/SgiPlatform.dsc                  | 1 +
> >  Platform/ARM/SgiPkg/SgiPlatform.fdf                  | 2 +-
> >  Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc    | 2 +-
> >  Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf    | 2 +-
> >  Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 1 +
> >  Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 2 +-
> >  Platform/Hisilicon/D03/D03.dsc                       | 1 +
> >  Platform/Hisilicon/D03/D03.fdf                       | 2 +-
> >  Platform/Hisilicon/D05/D05.dsc                       | 1 +
> >  Platform/Hisilicon/D05/D05.fdf                       | 2 +-
> >  Platform/Hisilicon/HiKey/HiKey.dsc                   | 1 +
> >  Platform/Hisilicon/HiKey/HiKey.fdf                   | 2 +-
> >  Platform/Hisilicon/HiKey960/HiKey960.dsc             | 1 +
> >  Platform/Hisilicon/HiKey960/HiKey960.fdf             | 2 +-
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc        | 1 +
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf            | 2 +-
> >  18 files changed, 18 insertions(+), 10 deletions(-)
> >
> > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
> > index 8d6dd0207d..ac3d63bd4d 100644
> > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc
> > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
> > @@ -293,6 +293,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >
> >    # Required by PCI
> >    ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf
> > diff --git a/Platform/ARM/JunoPkg/ArmJuno.fdf b/Platform/ARM/JunoPkg/ArmJuno.fdf
> > index c538a9b754..0a8b636d0e 100644
> > --- a/Platform/ARM/JunoPkg/ArmJuno.fdf
> > +++ b/Platform/ARM/JunoPkg/ArmJuno.fdf
> > @@ -142,7 +142,7 @@ FvNameGuid         = B73FE497-B92E-416e-8326-45AD0D270092
> >    #
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >
> >    # Required by PCI
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > index 2d8dcff94d..3f0ca9872e 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > @@ -264,6 +264,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >
> >    #
> >    # Bds
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > index 161ff92bbd..fd87563246 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > @@ -150,7 +150,7 @@ READ_LOCK_STATUS   = TRUE
> >    #
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >
> >    # FV FileSystem
> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> > index 6405d955f1..617164d42a 100644
> > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc
> > @@ -265,7 +265,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > -
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >    MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> >
> >    #
> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf
> > index 5786f117ea..ecd57f3a3e 100644
> > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf
> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf
> > @@ -123,7 +123,7 @@ FvNameGuid         = 73dcb643-3862-4904-9076-a94af1890243
> >    #
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >
> >    # Versatile Express FileSystem
> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> > index ca19fd6526..d20f1a7387 100644
> > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> > @@ -294,6 +294,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >
> >    #
> >    # Bds
> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
> > index 305e661a2b..239029d05c 100644
> > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf
> > @@ -128,7 +128,7 @@ FvNameGuid         = 87940482-fc81-41c3-87e6-399cf85ac8a0
> >    #
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >
> >    #
> > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> > index 116d591363..aa1da5d61f 100644
> > --- a/Platform/Hisilicon/D03/D03.dsc
> > +++ b/Platform/Hisilicon/D03/D03.dsc
> > @@ -430,6 +430,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >
> >    MdeModulePkg/Application/UiApp/UiApp.inf {
> >      <LibraryClasses>
> > diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
> > index b23765020d..f8a3c0cdaa 100644
> > --- a/Platform/Hisilicon/D03/D03.fdf
> > +++ b/Platform/Hisilicon/D03/D03.fdf
> > @@ -197,7 +197,7 @@ READ_LOCK_STATUS   = TRUE
> >    #
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >    INF IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf
> >
> > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
> > index a6bb65e71a..1040466633 100644
> > --- a/Platform/Hisilicon/D05/D05.dsc
> > +++ b/Platform/Hisilicon/D05/D05.dsc
> > @@ -584,6 +584,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >
> >    MdeModulePkg/Application/UiApp/UiApp.inf {
> >      <LibraryClasses>
> > diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf
> > index af2d20db9d..a933af3635 100644
> > --- a/Platform/Hisilicon/D05/D05.fdf
> > +++ b/Platform/Hisilicon/D05/D05.fdf
> > @@ -201,7 +201,7 @@ READ_LOCK_STATUS   = TRUE
> >    #
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >    INF IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf
> >
> > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> > index 9c1fc2e1b4..43bacfd146 100644
> > --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> > @@ -257,6 +257,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >
> >    #
> >    # Bds
> > diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf b/Platform/Hisilicon/HiKey/HiKey.fdf
> > index 2bca7232b6..577f05afb7 100644
> > --- a/Platform/Hisilicon/HiKey/HiKey.fdf
> > +++ b/Platform/Hisilicon/HiKey/HiKey.fdf
> > @@ -179,7 +179,7 @@ READ_LOCK_STATUS   = TRUE
> >    #
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >
> >    INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
> > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> > index be13714b9c..90a28b53cc 100644
> > --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
> > +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> > @@ -235,6 +235,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >
> >    #
> >    # Bds
> > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.fdf b/Platform/Hisilicon/HiKey960/HiKey960.fdf
> > index d65f778785..61cbe4e8a7 100644
> > --- a/Platform/Hisilicon/HiKey960/HiKey960.fdf
> > +++ b/Platform/Hisilicon/HiKey960/HiKey960.fdf
> > @@ -168,7 +168,7 @@ READ_LOCK_STATUS   = TRUE
> >    #
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >
> >    INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > index d4c67a2d11..ef5bcb757c 100644
> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > @@ -525,6 +525,7 @@
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > +  FatPkg/EnhancedFatDxe/Fat.inf
> >
> >    # Bds - Use Intel BDS
> >    MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
> > index c064a434b0..c5fbef5681 100644
> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
> > @@ -186,7 +186,7 @@ FvNameGuid         = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c
> >    # FAT filesystem + GPT/MBR partitioning
> >    INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> > +  INF FatPkg/EnhancedFatDxe/Fat.inf
> >    INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> >
> >    # UEFI application (Shell Embedded Boot Loader)
> > --
> > 2.18.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-10-22 15:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16  3:42 [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg shenglei
2018-10-17 13:10 ` Gao, Liming
2018-10-22 15:07   ` Gao, Liming [this message]
2018-10-22 16:50     ` Kinney, Michael D
2018-10-22 21:06     ` Ard Biesheuvel
2018-10-23  0:43       ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E34CE2E@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox