Re: [Patch] FDF Spec: Add the $(PCD) usage in the [FD] section

["Gao, Liming" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu
> Sent: Monday, October 22, 2018 3:49 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] FDF Spec: Add the $(PCD) usage in the [FD] section
> 
> current code support to use $(PCD) in the [FD] section, and lots of
> platform FDF file already used this usage, so we update the FDF spec
> first to align with code to reduce the incompatible change for
> firmware developer.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  2_fdf_design_discussion/24_[fd]_sections.md  | 2 +-
>  3_edk_ii_fdf_file_format/35_[fd]_sections.md | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/2_fdf_design_discussion/24_[fd]_sections.md b/2_fdf_design_discussion/24_[fd]_sections.md
> index e532041..67e478e 100644
> --- a/2_fdf_design_discussion/24_[fd]_sections.md
> +++ b/2_fdf_design_discussion/24_[fd]_sections.md
> @@ -162,11 +162,11 @@ For a PCD that has a datum type of `VOID`*, the data can be a Unicode string,
>  as in `L"text"`, a valid C data array (it must be either a C format GUID or a
>  hex byte array), as in `{0x20, 0x01, 0x50, 0x00, 0x32, 0xFF, 0x00, 0xAA, {0xFF, 0xF0, 0x00, 0x00, 0x00}}.`
>  For other PCD datum types, the value may be a boolean or a hex value, as in
>  `0x0000000F,` with a value that is consistent with the PCD's datum type.
> 
> -The value may also be a macro or it may be computed, using arithmetic
> +The value may also be a macro or `$(PCD)` or it may be computed, using arithmetic
>  operations, arithmetic expressions and or logical expressions. The value
>  portion of the `SET` statement, when using any of these computations are in-fix
>  expressions that are evaluated left to right, with items within parenthesis
>  evaluated before the outer expressions are evaluated. Use of parenthesis is
>  encouraged to remove ambiguity.
> diff --git a/3_edk_ii_fdf_file_format/35_[fd]_sections.md b/3_edk_ii_fdf_file_format/35_[fd]_sections.md
> index f0003e7..e46fd7b 100644
> --- a/3_edk_ii_fdf_file_format/35_[fd]_sections.md
> +++ b/3_edk_ii_fdf_file_format/35_[fd]_sections.md
> @@ -150,13 +150,13 @@ The `FvUiName` must be specified in a `[FV]` section header defined in this the
>  file.
> 
>  **_PcdValue_**
> 
>  The PCD Value may be a specific numeric value, an array of numeric bytes, a
> -GUID, a quoted string, an L quoted string (representing a unicode string), an
> +GUID, a quoted string, an `L` quoted string (representing a unicode string), an
>  arithmetic expression, a logic expression or a macro from a previously defined
> -macro statement.
> +macro statement or a `$(PCD) format.
> 
>  **_Expression_**
> 
>  Refer to the EDK II Expression Syntax Specification for more information.
> 
> --
> 2.6.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel