From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B22FD2117FD7A for ; Thu, 25 Oct 2018 00:32:42 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 00:32:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,423,1534834800"; d="scan'208";a="94869774" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 25 Oct 2018 00:32:42 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 00:32:42 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 00:32:41 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Thu, 25 Oct 2018 15:32:37 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Shaw, Kevin W" Thread-Topic: [edk2] [Patch] FDF Spec: Add the $(PCD) usage in the [FD] section Thread-Index: AQHUadvFztOpfo93xk611qRQLcRNF6Uvlg5g Date: Thu, 25 Oct 2018 07:32:36 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E35D0D0@SHSMSX104.ccr.corp.intel.com> References: <1540194547-14824-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1540194547-14824-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWNjYjRmNTctMWVkOS00MDYxLWJiNjktODE5NjQzYjhlYTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ0p2XC9VRVNIajhSS0dYQnFham5IN1BcL2pLMkJ0ck4ybEpwaDZwNzcrUXlMS051MktwOVN4akJTT1V0dUFsdEpRIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] FDF Spec: Add the $(PCD) usage in the [FD] section X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 07:32:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yo= nghong Zhu > Sent: Monday, October 22, 2018 3:49 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Shaw, Kevin W ; Gao, Liming > Subject: [edk2] [Patch] FDF Spec: Add the $(PCD) usage in the [FD] sectio= n >=20 > current code support to use $(PCD) in the [FD] section, and lots of > platform FDF file already used this usage, so we update the FDF spec > first to align with code to reduce the incompatible change for > firmware developer. >=20 > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > 2_fdf_design_discussion/24_[fd]_sections.md | 2 +- > 3_edk_ii_fdf_file_format/35_[fd]_sections.md | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/2_fdf_design_discussion/24_[fd]_sections.md b/2_fdf_design_d= iscussion/24_[fd]_sections.md > index e532041..67e478e 100644 > --- a/2_fdf_design_discussion/24_[fd]_sections.md > +++ b/2_fdf_design_discussion/24_[fd]_sections.md > @@ -162,11 +162,11 @@ For a PCD that has a datum type of `VOID`*, the dat= a can be a Unicode string, > as in `L"text"`, a valid C data array (it must be either a C format GUID= or a > hex byte array), as in `{0x20, 0x01, 0x50, 0x00, 0x32, 0xFF, 0x00, 0xAA,= {0xFF, 0xF0, 0x00, 0x00, 0x00}}.` > For other PCD datum types, the value may be a boolean or a hex value, as= in > `0x0000000F,` with a value that is consistent with the PCD's datum type. >=20 > -The value may also be a macro or it may be computed, using arithmetic > +The value may also be a macro or `$(PCD)` or it may be computed, using a= rithmetic > operations, arithmetic expressions and or logical expressions. The value > portion of the `SET` statement, when using any of these computations are= in-fix > expressions that are evaluated left to right, with items within parenthe= sis > evaluated before the outer expressions are evaluated. Use of parenthesis= is > encouraged to remove ambiguity. > diff --git a/3_edk_ii_fdf_file_format/35_[fd]_sections.md b/3_edk_ii_fdf_= file_format/35_[fd]_sections.md > index f0003e7..e46fd7b 100644 > --- a/3_edk_ii_fdf_file_format/35_[fd]_sections.md > +++ b/3_edk_ii_fdf_file_format/35_[fd]_sections.md > @@ -150,13 +150,13 @@ The `FvUiName` must be specified in a `[FV]` sectio= n header defined in this the > file. >=20 > **_PcdValue_** >=20 > The PCD Value may be a specific numeric value, an array of numeric bytes= , a > -GUID, a quoted string, an L quoted string (representing a unicode string= ), an > +GUID, a quoted string, an `L` quoted string (representing a unicode stri= ng), an > arithmetic expression, a logic expression or a macro from a previously d= efined > -macro statement. > +macro statement or a `$(PCD) format. >=20 > **_Expression_** >=20 > Refer to the EDK II Expression Syntax Specification for more information= . >=20 > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel