public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database update behaviors are atomic
Date: Fri, 26 Oct 2018 02:04:22 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E35EB25@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20181012112541.35880-1-dandan.bi@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Friday, October 12, 2018 7:26 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database update behaviors are atomic
> 
> The main purpose of this task is to make sure the operations
> that update the HiiDatabase atomic the avoid the potential
> risk that the one update operation with higher TPL may interrupt
> another.
> 
> Patch 1 is to reorgnize the existing code logic and make it's
> easy to add EfiAcquireLock/EfiReleaseLock function in patch 2.
> 
> Patch 2 is to add EfiAcquireLock/EfiReleaseLock function to
> make sure the HiiDatabse update operations atomic.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Dandan Bi (2):
>   MdeModulePkg/HiiDB: Reorganize codes of exporting HII settings
>   MdeModulePkg/HiiDB: Make sure database update behaviors are atomic
> 
>  .../Universal/HiiDatabaseDxe/Database.c       | 128 ++++++++++++------
>  .../Universal/HiiDatabaseDxe/HiiDatabase.h    |   8 +-
>  .../HiiDatabaseDxe/HiiDatabaseEntry.c         |   3 +-
>  MdeModulePkg/Universal/HiiDatabaseDxe/Image.c |  12 ++
>  .../Universal/HiiDatabaseDxe/String.c         |   9 ++
>  5 files changed, 112 insertions(+), 48 deletions(-)
> 
> --
> 2.18.0.windows.1



      parent reply	other threads:[~2018-10-26  2:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 11:25 [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database update behaviors are atomic Dandan Bi
2018-10-12 11:25 ` [patch 1/2] MdeModulePkg/HiiDB: Reorganize codes of exporting HII settings Dandan Bi
2018-10-12 11:25 ` [patch 2/2] MdeModulePkg/HiiDB: Make sure database update behaviors are atomic Dandan Bi
2018-10-26  2:04 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E35EB25@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox