From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5201C21C8EFB5 for ; Thu, 25 Oct 2018 19:04:25 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 19:04:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,426,1534834800"; d="scan'208";a="103387697" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 25 Oct 2018 19:04:25 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 19:04:25 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 19:04:25 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Fri, 26 Oct 2018 10:04:23 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database update behaviors are atomic Thread-Index: AQHUYh5aqBNL8yRX7UueZ3auk+1yzaUw3Cqg Date: Fri, 26 Oct 2018 02:04:22 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E35EB25@SHSMSX104.ccr.corp.intel.com> References: <20181012112541.35880-1-dandan.bi@intel.com> In-Reply-To: <20181012112541.35880-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODkzMTgwMTYtNjRiOC00ZTI1LTk0M2EtOGNhOWE2ODYwNWUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUm54SjBFclZvbmRlbFlcLzJGN08zdUg4N3psdVAwYmlvSkhzQ3NPRGRxTWZxelhHb1ljYWNBS2d1V1wvTlR2R3ZcLyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database update behaviors are atomic X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 02:04:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Bi, Dandan > Sent: Friday, October 12, 2018 7:26 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database upda= te behaviors are atomic >=20 > The main purpose of this task is to make sure the operations > that update the HiiDatabase atomic the avoid the potential > risk that the one update operation with higher TPL may interrupt > another. >=20 > Patch 1 is to reorgnize the existing code logic and make it's > easy to add EfiAcquireLock/EfiReleaseLock function in patch 2. >=20 > Patch 2 is to add EfiAcquireLock/EfiReleaseLock function to > make sure the HiiDatabse update operations atomic. >=20 > Cc: Liming Gao > Cc: Eric Dong > Dandan Bi (2): > MdeModulePkg/HiiDB: Reorganize codes of exporting HII settings > MdeModulePkg/HiiDB: Make sure database update behaviors are atomic >=20 > .../Universal/HiiDatabaseDxe/Database.c | 128 ++++++++++++------ > .../Universal/HiiDatabaseDxe/HiiDatabase.h | 8 +- > .../HiiDatabaseDxe/HiiDatabaseEntry.c | 3 +- > MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 12 ++ > .../Universal/HiiDatabaseDxe/String.c | 9 ++ > 5 files changed, 112 insertions(+), 48 deletions(-) >=20 > -- > 2.18.0.windows.1