From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE
Date: Fri, 26 Oct 2018 03:48:59 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E35ED47@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <bee9ef34-b3ec-0725-9d04-471cf47491a8@intel.com>
Star:
This option is not the default option. To pass GCC build, GCC tool chain adds it. XCODE tool chain doesn't require it, it is not listed for XCODE.
Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zeng, Star
> Sent: Friday, October 26, 2018 11:27 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE
>
> On 2018/10/26 10:33, Liming Gao wrote:
> > This patch makes RegularExpressionDxe pass XCODE5 build.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > ---
> > MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> > index df54716..7ccab57 100644
> > --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> > +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> > @@ -112,3 +112,7 @@
> >
> > # Oniguruma: tag_end in parse_callout_of_name
> > GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized
> > +
> > + # Not add -Wno-error=maybe-uninitialized option for XCODE
>
> Use "Eliminate" instead of "Not add" here? :)
>
> Anyway, Reviewed-by: Star Zeng <star.zeng@intel.com>.
>
> Thanks,
> Star
>
> > + # XCODE doesn't know this option
> > + XCODE:*_*_*_CC_FLAGS =
> >
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-10-26 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 2:33 [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE Liming Gao
2018-10-26 3:26 ` Zeng, Star
2018-10-26 3:48 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E35ED47@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox