From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F420C211799DD for ; Thu, 25 Oct 2018 20:49:02 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 20:49:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,426,1534834800"; d="scan'208";a="100810527" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 25 Oct 2018 20:49:02 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 20:49:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.84]) with mapi id 14.03.0415.000; Fri, 26 Oct 2018 11:49:00 +0800 From: "Gao, Liming" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE Thread-Index: AQHUbNRlh2v99XLTHUGxZ7iLVUshCaUwV6SAgACK37A= Date: Fri, 26 Oct 2018 03:48:59 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E35ED47@SHSMSX104.ccr.corp.intel.com> References: <20181026023324.23192-1-liming.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGZmNWU4ZjktNTUyNC00NDBlLTkxMmEtNmFlMWU1MTgzOGE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUjRSaEdPdkVuWWg2aXpLNGVZSXBRZGdvKzZ3RUhzNFF5OVZuamRWKzdNZzNXY1wvY3hJSlNMNGJEdXBrV2h2MEcifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 03:49:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star: This option is not the default option. To pass GCC build, GCC tool chain = adds it. XCODE tool chain doesn't require it, it is not listed for XCODE.=20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ze= ng, Star > Sent: Friday, October 26, 2018 11:27 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unk= nown build option for XCODE >=20 > On 2018/10/26 10:33, Liming Gao wrote: > > This patch makes RegularExpressionDxe pass XCODE5 build. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Liming Gao > > Cc: Star Zeng > > --- > > MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf = | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpress= ionDxe.inf > b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > > index df54716..7ccab57 100644 > > --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.= inf > > +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.= inf > > @@ -112,3 +112,7 @@ > > > > # Oniguruma: tag_end in parse_callout_of_name > > GCC:*_*_*_CC_FLAGS =3D -Wno-error=3Dmaybe-uninitialized > > + > > + # Not add -Wno-error=3Dmaybe-uninitialized option for XCODE >=20 > Use "Eliminate" instead of "Not add" here? :) >=20 > Anyway, Reviewed-by: Star Zeng . >=20 > Thanks, > Star >=20 > > + # XCODE doesn't know this option > > + XCODE:*_*_*_CC_FLAGS =3D > > >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel