* [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE @ 2018-10-26 2:33 Liming Gao 2018-10-26 3:26 ` Zeng, Star 0 siblings, 1 reply; 3+ messages in thread From: Liming Gao @ 2018-10-26 2:33 UTC (permalink / raw) To: edk2-devel; +Cc: Star Zeng This patch makes RegularExpressionDxe pass XCODE5 build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Star Zeng <star.zeng@intel.com> --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf index df54716..7ccab57 100644 --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf @@ -112,3 +112,7 @@ # Oniguruma: tag_end in parse_callout_of_name GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized + + # Not add -Wno-error=maybe-uninitialized option for XCODE + # XCODE doesn't know this option + XCODE:*_*_*_CC_FLAGS = -- 2.10.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE 2018-10-26 2:33 [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE Liming Gao @ 2018-10-26 3:26 ` Zeng, Star 2018-10-26 3:48 ` Gao, Liming 0 siblings, 1 reply; 3+ messages in thread From: Zeng, Star @ 2018-10-26 3:26 UTC (permalink / raw) To: Liming Gao, edk2-devel; +Cc: star.zeng On 2018/10/26 10:33, Liming Gao wrote: > This patch makes RegularExpressionDxe pass XCODE5 build. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao <liming.gao@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > --- > MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > index df54716..7ccab57 100644 > --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > @@ -112,3 +112,7 @@ > > # Oniguruma: tag_end in parse_callout_of_name > GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized > + > + # Not add -Wno-error=maybe-uninitialized option for XCODE Use "Eliminate" instead of "Not add" here? :) Anyway, Reviewed-by: Star Zeng <star.zeng@intel.com>. Thanks, Star > + # XCODE doesn't know this option > + XCODE:*_*_*_CC_FLAGS = > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE 2018-10-26 3:26 ` Zeng, Star @ 2018-10-26 3:48 ` Gao, Liming 0 siblings, 0 replies; 3+ messages in thread From: Gao, Liming @ 2018-10-26 3:48 UTC (permalink / raw) To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Zeng, Star Star: This option is not the default option. To pass GCC build, GCC tool chain adds it. XCODE tool chain doesn't require it, it is not listed for XCODE. Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zeng, Star > Sent: Friday, October 26, 2018 11:27 AM > To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.zeng@intel.com> > Subject: Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE > > On 2018/10/26 10:33, Liming Gao wrote: > > This patch makes RegularExpressionDxe pass XCODE5 build. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Liming Gao <liming.gao@intel.com> > > Cc: Star Zeng <star.zeng@intel.com> > > --- > > MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > > index df54716..7ccab57 100644 > > --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > > +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > > @@ -112,3 +112,7 @@ > > > > # Oniguruma: tag_end in parse_callout_of_name > > GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized > > + > > + # Not add -Wno-error=maybe-uninitialized option for XCODE > > Use "Eliminate" instead of "Not add" here? :) > > Anyway, Reviewed-by: Star Zeng <star.zeng@intel.com>. > > Thanks, > Star > > > + # XCODE doesn't know this option > > + XCODE:*_*_*_CC_FLAGS = > > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-26 3:49 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-10-26 2:33 [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE Liming Gao 2018-10-26 3:26 ` Zeng, Star 2018-10-26 3:48 ` Gao, Liming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox