From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, YunhuaX" <yunhuax.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 1/1] BaseTools: Roll back code modify by commit 9e47e6f90880
Date: Fri, 26 Oct 2018 06:19:25 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E35F128@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <47C64442C08CCD4089DC43B6B5E46BC49077EC@shsmsx102.ccr.corp.intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Because some platform has been broken, I will push this patch soon.
> -----Original Message-----
> From: Feng, YunhuaX
> Sent: Friday, October 26, 2018 2:08 PM
> To: edk2-devel@lists.01.org
> Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH 1/1] BaseTools: Roll back code modify by commit 9e47e6f90880
>
> Roll back code modify by commit 9e47e6f90880,
> if ForceRebase not False or True, the GenFv command not need add parameter
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
> ---
> BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> index e867693d7c..ea61f723a7 100644
> --- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> +++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> @@ -572,13 +572,13 @@ class GenFdsGlobalVariable:
>
> Cmd = ["GenFv"]
> if BaseAddress:
> Cmd += ("-r", BaseAddress)
>
> - if not ForceRebase:
> + if ForceRebase == False:
> Cmd += ("-F", "FALSE")
> - else:
> + elif ForceRebase == True:
> Cmd += ("-F", "TRUE")
>
> if Capsule:
> Cmd.append("-c")
> if Dump:
> --
> 2.12.2.windows.2
prev parent reply other threads:[~2018-10-26 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 6:07 [PATCH 1/1] BaseTools: Roll back code modify by commit 9e47e6f90880 Feng, YunhuaX
2018-10-26 6:19 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E35F128@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox