public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure.
Date: Sat, 27 Oct 2018 14:30:39 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3608D8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20181027090921.6180-1-eric.dong@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Dong, Eric
> Sent: Saturday, October 27, 2018 5:09 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h    | 2 +-
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> index b5fe8fbce1..b4c8ab777e 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> @@ -203,7 +203,7 @@ CPU_FEATURE_DEPENDENCE_TYPE
>  DetectFeatureScope (
>    IN CPU_FEATURES_ENTRY         *CpuFeature,
>    IN BOOLEAN                    Before,
> -  IN CHAR8                      *NextCpuFeatureMask
> +  IN UINT8                      *NextCpuFeatureMask
>    );
> 
>  /**
> diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> index 9a66bc49ff..394695baf2 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> @@ -125,7 +125,7 @@ CPU_FEATURE_DEPENDENCE_TYPE
>  DetectFeatureScope (
>    IN CPU_FEATURES_ENTRY         *CpuFeature,
>    IN BOOLEAN                    Before,
> -  IN CHAR8                      *NextCpuFeatureMask
> +  IN UINT8                      *NextCpuFeatureMask
>    )
>  {
>    //
> --
> 2.16.2.windows.1



  reply	other threads:[~2018-10-27 14:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-27  9:09 [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure Eric Dong
2018-10-27 14:30 ` Gao, Liming [this message]
2018-10-29 11:34 ` Leif Lindholm
2018-10-29 23:40   ` Dong, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3608D8@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox