From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EF86A2118849F for ; Thu, 1 Nov 2018 06:31:25 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2018 06:31:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,452,1534834800"; d="scan'208,217";a="92943226" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 01 Nov 2018 06:31:24 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 1 Nov 2018 06:31:24 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 1 Nov 2018 06:31:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Thu, 1 Nov 2018 21:31:21 +0800 From: "Gao, Liming" To: Jeff Brasen , "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Thread-Index: AQHUcJfyRcYnul8yWkemGcYQVj6zCqU4h/wAgAFoDoCAAPo3YA== Date: Thu, 1 Nov 2018 13:31:21 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3634BC@SHSMSX104.ccr.corp.intel.com> References: , <734D49CCEBEEF84792F5B80ED585239D5BEE8DCE@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzBiNTY0MGUtOWNhNC00ZDI0LThmYjItM2RhN2ZiOTFiOGM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSWd2MEo1ZVpIOUVJVVVnVk5cL3RpY1NWYTFsQnNEV2U2M2dvNnNwaHhxWjVQcU1tTVF6aTR1YmU2XC9DTXhWK1hMIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 13:31:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jeff: Thanks for your case. PrePiMemoryAllocationLib is a MemoryAllocationLib i= mplementation that doesn't depend on PEI or DXE service. So, MemoryAllocati= onLib may be used in BASE type. And, I find MdeModulePkg\Library\BaseBmpSup= portLib\BaseBmpSupportLib.inf is BASE type and consumes MemoryAllocationLib= . So, I think your change is OK. Reviewed-by: Liming Gao Thanks Liming From: Jeff Brasen [mailto:jbrasen@nvidia.com] Sent: Thursday, November 1, 2018 2:25 PM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Gao, Liming ; Kinney, Michael D Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all mo= dule types For defining it as a BASE type i changed that to that as there is a MemoryA= llocationLib defined for the various phases. For example, SEC uses Embedded= Pkg/Library/PrePiMemoryAllocationLib (other patch in this series implements= the AllocateZeroPool that is needed for this). I am not opposed to an allocation-less SortLib but was trying to enable thi= s capability without impact to other users of this library. Thanks, Jeff ________________________________ From: Ni, Ruiyu > Sent: Wednesday, October 31, 2018 2:56:42 AM To: Jeff Brasen; edk2-devel@lists.01.org Cc: Gao, Liming; Kinney, Michael D Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all mo= dule types SortLib depends on MemoryAllocationLib. How can it be a BASE type library? Can we do it in two options? 1. Change the SortLib API to accept a temporary buffer from caller. So the = MemoryAllocationlIb dependency can be removed. 2. Do not change SortLibAPI but uses a fixed-size temporary buffer internal= ly. E.g.: UINT8 Buffer[MAX_ELEMENT_SIZE]; Thanks/Ray > -----Original Message----- > From: edk2-devel > On Behalf Of Jeff > Brasen > Sent: Wednesday, October 31, 2018 5:31 AM > To: edk2-devel@lists.01.org > Cc: Jeff Brasen > > Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all > module types > > Expose BaseSortLib for use in SEC and PEI phases. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jeff Brasen = > > --- > MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > index f807cd7..5bd1aa1 100644 > --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > @@ -18,9 +18,9 @@ > BASE_NAME =3D BaseSortLib > MODULE_UNI_FILE =3D BaseSortLib.uni > FILE_GUID =3D 03F3331B-F12D-494f-BF37-E55A657F249= 7 > - MODULE_TYPE =3D UEFI_DRIVER > + MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D SortLib|DXE_DRIVER DXE_RUNTIME_DRIV= ER > UEFI_APPLICATION UEFI_DRIVER > + LIBRARY_CLASS =3D SortLib > > # > # VALID_ARCHITECTURES =3D IA32 X64 EBC > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ________________________________ This email message is for the sole use of the intended recipient(s) and may= contain confidential information. Any unauthorized review, use, disclosur= e or distribution is prohibited. If you are not the intended recipient, pl= ease contact the sender by reply email and destroy all copies of the origin= al message. ________________________________