From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B6E852117D285 for ; Thu, 1 Nov 2018 18:39:26 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2018 18:39:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,454,1534834800"; d="scan'208";a="104744350" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 01 Nov 2018 18:39:25 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 1 Nov 2018 18:39:25 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.84]) with mapi id 14.03.0415.000; Fri, 2 Nov 2018 09:39:24 +0800 From: "Gao, Liming" To: Leif Lindholm , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM Thread-Index: AQHUcfi6RA3uPqGDEECAkvjfsAEV+KU7tFtQ Date: Fri, 2 Nov 2018 01:39:24 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E36382B@SHSMSX104.ccr.corp.intel.com> References: <20181101153642.11315-1-leif.lindholm@linaro.org> <20181101153642.11315-3-leif.lindholm@linaro.org> In-Reply-To: <20181101153642.11315-3-leif.lindholm@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 01:39:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: There is one mistake in comments >+ #^M. Could you clean it? With this = change, Reviewed-by: Liming Gao .=20 Besides, have you verified AARCH64 GCC build?=20 Thanks Liming >-----Original Message----- >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >Sent: Thursday, November 01, 2018 11:37 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM > >Contrary to what the name suggests, some modules in this package are used >on other architecture. ARM is already listed in SUPPORTED_ARCHITECTURES >in the .dsc, but AARCH64 was never added. > >Add that, and force inclusion of CompilerIntrinsicsLib and >BaseStackCheckLib for AARCH64/ARM to make the build successful. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Leif Lindholm >--- > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 13 >++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > >diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >index 894c5340a0..14bef5356e 100644 >--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc >@@ -25,7 +25,7 @@ [Defines] > PLATFORM_VERSION =3D 0.96 > DSC_SPECIFICATION =3D 0x00010005 > OUTPUT_DIRECTORY =3D Build/IntelFrameworkModuleAll >- SUPPORTED_ARCHITECTURES =3D IA32|X64|EBC|ARM >+ SUPPORTED_ARCHITECTURES =3D IA32|X64|EBC|ARM|AARCH64 > BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER =3D DEFAULT > >@@ -76,6 +76,17 @@ [LibraryClasses] > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > >+[LibraryClasses.ARM, LibraryClasses.AARCH64] >+ # >+ # It is not possible to prevent the ARM compiler for generic intrinsic >functions. >+ # This library provides the instrinsic functions generate by a given co= mpiler. >+ # And NULL mean link this library into all ARM images. >+ #^M >+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >+ >+ # Add support for GCC stack protector >+ NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >+ > [LibraryClasses.common.PEIM] > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf >-- >2.11.0