Re: [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

["Gao, Liming" <liming.gao@intel.com>]

Yes. I will wait for another patch in this patch set to be reviewed. 

>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, November 02, 2018 1:00 PM
>To: Gao, Liming <liming.gao@intel.com>; Jeff Brasen <jbrasen@nvidia.com>;
>Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all
>module types
>
>Liming,
>
>Will you help push the patch series?
>
>
>Thanks,
>Star
>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao,
>Liming
>Sent: Thursday, November 1, 2018 9:31 PM
>To: Jeff Brasen <jbrasen@nvidia.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-
>devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all
>module types
>
>Jeff:
>  Thanks for your case. PrePiMemoryAllocationLib is a MemoryAllocationLib
>implementation that doesn't depend on PEI or DXE service. So,
>MemoryAllocationLib may be used in BASE type. And, I find
>MdeModulePkg\Library\BaseBmpSupportLib\BaseBmpSupportLib.inf is BASE
>type and consumes MemoryAllocationLib. So, I think your change is OK.
>Reviewed-by: Liming Gao <liming.gao@intel.com>
>
>Thanks
>Liming
>From: Jeff Brasen [mailto:jbrasen@nvidia.com]
>Sent: Thursday, November 1, 2018 2:25 PM
>To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all
>module types
>
>
>For defining it as a BASE type i changed that to that as there is a
>MemoryAllocationLib defined for the various phases. For example, SEC uses
>EmbeddedPkg/Library/PrePiMemoryAllocationLib (other patch in this series
>implements the AllocateZeroPool that is needed for this).
>
>
>
>I am not opposed to an allocation-less SortLib but was trying to enable this
>capability without impact to other users of this library.
>
>
>
>Thanks,
>
>Jeff
>
>________________________________
>From: Ni, Ruiyu <ruiyu.ni@intel.com<mailto:ruiyu.ni@intel.com>>
>Sent: Wednesday, October 31, 2018 2:56:42 AM
>To: Jeff Brasen; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>Cc: Gao, Liming; Kinney, Michael D
>Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all
>module types
>
>SortLib depends on MemoryAllocationLib.
>How can it be a BASE type library?
>
>Can we do it in two options?
>1. Change the SortLib API to accept a temporary buffer from caller. So the
>MemoryAllocationlIb dependency can be removed.
>2. Do not change SortLibAPI but uses a fixed-size temporary buffer internally.
>E.g.: UINT8 Buffer[MAX_ELEMENT_SIZE];
>
>
>Thanks/Ray
>
>> -----Original Message-----
>> From: edk2-devel
>> <edk2-devel-bounces@lists.01.org<mailto:edk2-devel-bounces@lists.01.or
>> g>> On Behalf Of Jeff Brasen
>> Sent: Wednesday, October 31, 2018 5:31 AM
>> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> Cc: Jeff Brasen <jbrasen@nvidia.com<mailto:jbrasen@nvidia.com>>
>> Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all
>> module types
>>
>> Expose BaseSortLib for use in SEC and PEI phases.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Jeff Brasen
>> <jbrasen@nvidia.com<mailto:jbrasen@nvidia.com>>
>> ---
>>  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>> b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>> index f807cd7..5bd1aa1 100644
>> --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>> +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>> @@ -18,9 +18,9 @@
>>    BASE_NAME                      = BaseSortLib
>>    MODULE_UNI_FILE                = BaseSortLib.uni
>>    FILE_GUID                      = 03F3331B-F12D-494f-BF37-E55A657F2497
>> -  MODULE_TYPE                    = UEFI_DRIVER
>> +  MODULE_TYPE                    = BASE
>>    VERSION_STRING                 = 1.0
>> -  LIBRARY_CLASS                  = SortLib|DXE_DRIVER DXE_RUNTIME_DRIVER
>> UEFI_APPLICATION UEFI_DRIVER
>> +  LIBRARY_CLASS                  = SortLib
>>
>>  #
>>  #  VALID_ARCHITECTURES           = IA32 X64 EBC
>> --
>> 2.7.4
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
>> https://lists.01.org/mailman/listinfo/edk2-devel
>________________________________
>This email message is for the sole use of the intended recipient(s) and may
>contain confidential information.  Any unauthorized review, use, disclosure or
>distribution is prohibited.  If you are not the intended recipient, please contact
>the sender by reply email and destroy all copies of the original message.
>________________________________
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel