From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 55BB821189FB9 for ; Fri, 2 Nov 2018 00:45:44 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2018 00:45:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,454,1534834800"; d="scan'208";a="83472060" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 02 Nov 2018 00:45:43 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Nov 2018 00:45:43 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Nov 2018 00:45:43 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Fri, 2 Nov 2018 15:45:41 +0800 From: "Gao, Liming" To: "Zeng, Star" , Jeff Brasen , "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Thread-Index: AQHUcJfyRcYnul8yWkemGcYQVj6zCqU4h/wAgAFoDoCAAPo3YIAAgDcAgAC0SBA= Date: Fri, 2 Nov 2018 07:45:40 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E363C10@SHSMSX104.ccr.corp.intel.com> References: , <734D49CCEBEEF84792F5B80ED585239D5BEE8DCE@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3634BC@SHSMSX104.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB048310401E6A09@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB048310401E6A09@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 07:45:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. I will wait for another patch in this patch set to be reviewed.=20 >-----Original Message----- >From: Zeng, Star >Sent: Friday, November 02, 2018 1:00 PM >To: Gao, Liming ; Jeff Brasen ; >Ni, Ruiyu ; edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >; Zeng, Star >Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >module types > >Liming, > >Will you help push the patch series? > > >Thanks, >Star > >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao= , >Liming >Sent: Thursday, November 1, 2018 9:31 PM >To: Jeff Brasen ; Ni, Ruiyu ; edk2= - >devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >module types > >Jeff: > Thanks for your case. PrePiMemoryAllocationLib is a MemoryAllocationLib >implementation that doesn't depend on PEI or DXE service. So, >MemoryAllocationLib may be used in BASE type. And, I find >MdeModulePkg\Library\BaseBmpSupportLib\BaseBmpSupportLib.inf is BASE >type and consumes MemoryAllocationLib. So, I think your change is OK. >Reviewed-by: Liming Gao > >Thanks >Liming >From: Jeff Brasen [mailto:jbrasen@nvidia.com] >Sent: Thursday, November 1, 2018 2:25 PM >To: Ni, Ruiyu ; edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D > >Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >module types > > >For defining it as a BASE type i changed that to that as there is a >MemoryAllocationLib defined for the various phases. For example, SEC uses >EmbeddedPkg/Library/PrePiMemoryAllocationLib (other patch in this series >implements the AllocateZeroPool that is needed for this). > > > >I am not opposed to an allocation-less SortLib but was trying to enable th= is >capability without impact to other users of this library. > > > >Thanks, > >Jeff > >________________________________ >From: Ni, Ruiyu > >Sent: Wednesday, October 31, 2018 2:56:42 AM >To: Jeff Brasen; edk2-devel@lists.01.org >Cc: Gao, Liming; Kinney, Michael D >Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >module types > >SortLib depends on MemoryAllocationLib. >How can it be a BASE type library? > >Can we do it in two options? >1. Change the SortLib API to accept a temporary buffer from caller. So the >MemoryAllocationlIb dependency can be removed. >2. Do not change SortLibAPI but uses a fixed-size temporary buffer interna= lly. >E.g.: UINT8 Buffer[MAX_ELEMENT_SIZE]; > > >Thanks/Ray > >> -----Original Message----- >> From: edk2-devel >> > g>> On Behalf Of Jeff Brasen >> Sent: Wednesday, October 31, 2018 5:31 AM >> To: edk2-devel@lists.01.org >> Cc: Jeff Brasen > >> Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all >> module types >> >> Expose BaseSortLib for use in SEC and PEI phases. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Jeff Brasen >> > >> --- >> MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> index f807cd7..5bd1aa1 100644 >> --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> @@ -18,9 +18,9 @@ >> BASE_NAME =3D BaseSortLib >> MODULE_UNI_FILE =3D BaseSortLib.uni >> FILE_GUID =3D 03F3331B-F12D-494f-BF37-E55A657F24= 97 >> - MODULE_TYPE =3D UEFI_DRIVER >> + MODULE_TYPE =3D BASE >> VERSION_STRING =3D 1.0 >> - LIBRARY_CLASS =3D SortLib|DXE_DRIVER DXE_RUNTIME_DRI= VER >> UEFI_APPLICATION UEFI_DRIVER >> + LIBRARY_CLASS =3D SortLib >> >> # >> # VALID_ARCHITECTURES =3D IA32 X64 EBC >> -- >> 2.7.4 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel >________________________________ >This email message is for the sole use of the intended recipient(s) and ma= y >contain confidential information. Any unauthorized review, use, disclosur= e or >distribution is prohibited. If you are not the intended recipient, please= contact >the sender by reply email and destroy all copies of the original message. >________________________________ >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel