From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C4BF21189FB9 for ; Fri, 2 Nov 2018 07:20:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2018 07:20:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,456,1534834800"; d="scan'208";a="104749714" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 02 Nov 2018 07:20:19 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Nov 2018 07:20:19 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Nov 2018 07:20:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Fri, 2 Nov 2018 22:20:17 +0800 From: "Gao, Liming" To: Leif Lindholm CC: "edk2-devel@lists.01.org" Thread-Topic: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM Thread-Index: AQHUcfi6RA3uPqGDEECAkvjfsAEV+KU7tFtQgAALcoCAAMprUA== Date: Fri, 2 Nov 2018 14:20:16 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E363FC4@SHSMSX104.ccr.corp.intel.com> References: <20181101153642.11315-1-leif.lindholm@linaro.org> <20181101153642.11315-3-leif.lindholm@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E36382B@SHSMSX104.ccr.corp.intel.com> <20181102101506.wa6b2pnlvkww4gif@bivouac.eciton.net> In-Reply-To: <20181102101506.wa6b2pnlvkww4gif@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjNiZDk1YmYtNGY3Yi00Yjc3LWFhNjctZGJlMDkyYzE5NjlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicHU5ZlFmajFyOUhWTDVQQWdDZzJZeWI1RzFLZVlPN245OU5wWXRMVWJJNG9rcWRKanIrRHpwZ2hYTW44MFwvMEEifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 14:20:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That's good. Thanks! > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Friday, November 2, 2018 6:15 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/A= RM >=20 > On Fri, Nov 02, 2018 at 01:39:24AM +0000, Gao, Liming wrote: > > Leif: > > There is one mistake in comments >+ #^M. Could you clean it? > > With this change, Reviewed-by: Liming Gao . >=20 > Whoops, thanks for spotting. > Will do. >=20 > > Besides, have you verified AARCH64 GCC build? >=20 > AARCH64 and ARM, GCC5 and CLANG38. >=20 > Several modules from this package are already used by ARM/AARCH64 > platforms, it was just not working to build only the package. >=20 > Regards, >=20 > Leif >=20 > > Thanks > > Liming > > >-----Original Message----- > > >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > >Sent: Thursday, November 01, 2018 11:37 PM > > >To: edk2-devel@lists.01.org > > >Cc: Gao, Liming > > >Subject: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/AR= M > > > > > >Contrary to what the name suggests, some modules in this package are u= sed > > >on other architecture. ARM is already listed in SUPPORTED_ARCHITECTURE= S > > >in the .dsc, but AARCH64 was never added. > > > > > >Add that, and force inclusion of CompilerIntrinsicsLib and > > >BaseStackCheckLib for AARCH64/ARM to make the build successful. > > > > > >Cc: Liming Gao > > >Contributed-under: TianoCore Contribution Agreement 1.1 > > >Signed-off-by: Leif Lindholm > > >--- > > > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 13 > > >++++++++++++- > > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > > >diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > > >b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > > >index 894c5340a0..14bef5356e 100644 > > >--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > > >+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > > >@@ -25,7 +25,7 @@ [Defines] > > > PLATFORM_VERSION =3D 0.96 > > > DSC_SPECIFICATION =3D 0x00010005 > > > OUTPUT_DIRECTORY =3D Build/IntelFrameworkModuleAll > > >- SUPPORTED_ARCHITECTURES =3D IA32|X64|EBC|ARM > > >+ SUPPORTED_ARCHITECTURES =3D IA32|X64|EBC|ARM|AARCH64 > > > BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT > > > SKUID_IDENTIFIER =3D DEFAULT > > > > > >@@ -76,6 +76,17 @@ [LibraryClasses] > > > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > > > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > > > > > >+[LibraryClasses.ARM, LibraryClasses.AARCH64] > > >+ # > > >+ # It is not possible to prevent the ARM compiler for generic intrin= sic > > >functions. > > >+ # This library provides the instrinsic functions generate by a give= n compiler. > > >+ # And NULL mean link this library into all ARM images. > > >+ #^M > > >+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > >+ > > >+ # Add support for GCC stack protector > > >+ NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > >+ > > > [LibraryClasses.common.PEIM] > > > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > > > PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf > > >-- > > >2.11.0 > >