Plan to move all network components to NetworkPkg

Plan to move all network components to NetworkPkg

[Fu, Siyuan]

Hi, All

The edk2 Bugzilla #1278 "Delete IPv4 only TCP/iSCSI/PXE drivers in MdeModulePkg" has been confirmed to be included in edk2-stable201903 tag, so platform DSC/FDF need to be updated to adopt the change by that time. I think might be an opportunity moment to make a little more - move all edk2 network related drivers/libraries into one single package - that what we want to do for a long time.

In current edk2, the network stack components are located mainly in 2 different places, the MdeModulePkg and NetworkPkg, due to some historical reasons. The MdeModulePkg contains most of the IPv4 stack drivers (in MdeModulePkg/Universal/Network directory), and all the network libraries. The NetworkPkg contains all the IPv6 stack drivers and also some dual stack drivers (like TcpDxe). The PCDs related to network configuration are also defined in different packages: PcdTftpBlockSize is in MdeModulePkg.dec and others are in NetworkPkg.dec. There are also drivers in these 2 packages have a same name (like UefiPxeBcDxe).

We can see these codes are not well organized, so I'd like to take this opportunity to change this situation, to move all network components to NetworkPkg, which will make the edk2 network stack code easier to use and maintain in the future.

I have created Bugzilla #1293 for this proposal, and I will send some patches for the detail changes. I hope it could be done together with #1278 so the platform only need to update their DSC/FDF file for one time. Please let me know if you have any comments on this, thanks.

https://bugzilla.tianocore.org/show_bug.cgi?id=1293

BestRegards
Fu Siyuan

Re: Plan to move all network components to NetworkPkg

[Gao, Liming]

Siyuan:
  Could you list the mapping between current location and new location of Network IPv4 stack? It will be easy to be understood. 

  And, I prefer to change the platform DSC/FDF per each BZ. That means I expect two commits in DSC/FDF. One is for BZ 1278, another is for 1293. The different commit is for the different change. 

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu, Siyuan
> Sent: Friday, November 2, 2018 4:10 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Ye, Ting <ting.ye@intel.com>
> Subject: [edk2] Plan to move all network components to NetworkPkg
> 
> Hi, All
> 
> The edk2 Bugzilla #1278 "Delete IPv4 only TCP/iSCSI/PXE drivers in MdeModulePkg" has been confirmed to be included in
> edk2-stable201903 tag, so platform DSC/FDF need to be updated to adopt the change by that time. I think might be an opportunity
> moment to make a little more - move all edk2 network related drivers/libraries into one single package - that what we want to do for a
> long time.
> 
> In current edk2, the network stack components are located mainly in 2 different places, the MdeModulePkg and NetworkPkg, due to
> some historical reasons. The MdeModulePkg contains most of the IPv4 stack drivers (in MdeModulePkg/Universal/Network directory),
> and all the network libraries. The NetworkPkg contains all the IPv6 stack drivers and also some dual stack drivers (like TcpDxe). The
> PCDs related to network configuration are also defined in different packages: PcdTftpBlockSize is in MdeModulePkg.dec and others are
> in NetworkPkg.dec. There are also drivers in these 2 packages have a same name (like UefiPxeBcDxe).
> 
> We can see these codes are not well organized, so I'd like to take this opportunity to change this situation, to move all network
> components to NetworkPkg, which will make the edk2 network stack code easier to use and maintain in the future.
> 
> I have created Bugzilla #1293 for this proposal, and I will send some patches for the detail changes. I hope it could be done together
> with #1278 so the platform only need to update their DSC/FDF file for one time. Please let me know if you have any comments on this,
> thanks.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1293
> 
> BestRegards
> Fu Siyuan
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: Plan to move all network components to NetworkPkg

[Ni, Ruiyu]

Siyuan,
This is a good idea. Will the driver name be changed after the location change? Or as Liming suggested, maybe you could provide a text format directory tree layout to show what the final NetworkPkg is like.

Thanks/Ray

From: Fu, Siyuan
Sent: Friday, November 2, 2018 4:10 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>
Subject: Plan to move all network components to NetworkPkg

Hi, All

The edk2 Bugzilla #1278 "Delete IPv4 only TCP/iSCSI/PXE drivers in MdeModulePkg" has been confirmed to be included in edk2-stable201903 tag, so platform DSC/FDF need to be updated to adopt the change by that time. I think might be an opportunity moment to make a little more - move all edk2 network related drivers/libraries into one single package - that what we want to do for a long time.

In current edk2, the network stack components are located mainly in 2 different places, the MdeModulePkg and NetworkPkg, due to some historical reasons. The MdeModulePkg contains most of the IPv4 stack drivers (in MdeModulePkg/Universal/Network directory), and all the network libraries. The NetworkPkg contains all the IPv6 stack drivers and also some dual stack drivers (like TcpDxe). The PCDs related to network configuration are also defined in different packages: PcdTftpBlockSize is in MdeModulePkg.dec and others are in NetworkPkg.dec. There are also drivers in these 2 packages have a same name (like UefiPxeBcDxe).

We can see these codes are not well organized, so I'd like to take this opportunity to change this situation, to move all network components to NetworkPkg, which will make the edk2 network stack code easier to use and maintain in the future.

I have created Bugzilla #1293 for this proposal, and I will send some patches for the detail changes. I hope it could be done together with #1278 so the platform only need to update their DSC/FDF file for one time. Please let me know if you have any comments on this, thanks.

https://bugzilla.tianocore.org/show_bug.cgi?id=1293

BestRegards
Fu Siyuan

Re: Plan to move all network components to NetworkPkg

[Zeng, Star]

We'd better also moving the header file (in Guid and Library directory), library instances and PCDs.


Thanks,
Star
From: Ni, Ruiyu
Sent: Monday, November 5, 2018 10:22 AM
To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>
Subject: RE: Plan to move all network components to NetworkPkg

Siyuan,
This is a good idea. Will the driver name be changed after the location change? Or as Liming suggested, maybe you could provide a text format directory tree layout to show what the final NetworkPkg is like.

Thanks/Ray

From: Fu, Siyuan
Sent: Friday, November 2, 2018 4:10 PM
To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>; Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; Ni, Ruiyu <ruiyu.ni@intel.com<mailto:ruiyu.ni@intel.com>>; Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>; Ye, Ting <ting.ye@intel.com<mailto:ting.ye@intel.com>>
Subject: Plan to move all network components to NetworkPkg

Hi, All

The edk2 Bugzilla #1278 "Delete IPv4 only TCP/iSCSI/PXE drivers in MdeModulePkg" has been confirmed to be included in edk2-stable201903 tag, so platform DSC/FDF need to be updated to adopt the change by that time. I think might be an opportunity moment to make a little more - move all edk2 network related drivers/libraries into one single package - that what we want to do for a long time.

In current edk2, the network stack components are located mainly in 2 different places, the MdeModulePkg and NetworkPkg, due to some historical reasons. The MdeModulePkg contains most of the IPv4 stack drivers (in MdeModulePkg/Universal/Network directory), and all the network libraries. The NetworkPkg contains all the IPv6 stack drivers and also some dual stack drivers (like TcpDxe). The PCDs related to network configuration are also defined in different packages: PcdTftpBlockSize is in MdeModulePkg.dec and others are in NetworkPkg.dec. There are also drivers in these 2 packages have a same name (like UefiPxeBcDxe).

We can see these codes are not well organized, so I'd like to take this opportunity to change this situation, to move all network components to NetworkPkg, which will make the edk2 network stack code easier to use and maintain in the future.

I have created Bugzilla #1293 for this proposal, and I will send some patches for the detail changes. I hope it could be done together with #1278 so the platform only need to update their DSC/FDF file for one time. Please let me know if you have any comments on this, thanks.

https://bugzilla.tianocore.org/show_bug.cgi?id=1293

BestRegards
Fu Siyuan