From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC3B021A00AE6 for ; Thu, 8 Nov 2018 05:56:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2018 05:56:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,478,1534834800"; d="scan'208";a="106528906" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 08 Nov 2018 05:56:06 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 8 Nov 2018 05:56:06 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 8 Nov 2018 05:56:05 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.161]) with mapi id 14.03.0415.000; Thu, 8 Nov 2018 21:56:04 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Kinney, Michael D" Thread-Topic: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx Thread-Index: AQHUd2nqlhGJsEmJLEiouX8jRMPQeKVF5rgA Date: Thu, 8 Nov 2018 13:56:03 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E367885@SHSMSX104.ccr.corp.intel.com> References: <20181108134935.51312-1-dandan.bi@intel.com> In-Reply-To: <20181108134935.51312-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY4MjZhYzgtMjc4Yi00ZjFlLTlkMTAtN2I5ZmQxMmU4NmMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTUZBSkRqZkV3QXRGZ1Y4aHRMRnFpWEhhVkt5R2lUVjBJY0ZNMnJoWURMckV5V3U1Q2VBVk85RWtrNWpuZVJmeCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 13:56:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, November 8, 2018 9:50 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Kinney, Michael D ; Gao, Liming > Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text format = in AcpiEx >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1312 >=20 > Text format for AcpiEx device path in UEFI Spec: > AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR) > AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only) >=20 > When convert device path to text for ACPI device path, > current code check AllowShortcuts parameter to convert > the device path to DisplayOnly text format(shorter text > representation) by mistake. > It should check DisplayOnly parameter. >=20 > This commit is to fix this issue. >=20 > Cc: Ruiyu Ni > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg= /Library/UefiDevicePathLib/DevicePathToText.c > index cdcdb3623a..97d279eeb2 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > @@ -495,11 +495,11 @@ DevPathToTextAcpiEx ( > CIDText, > UIDStr > ); > } > } else { > - if (AllowShortcuts) { > + if (DisplayOnly) { > // > // display only > // > if (AcpiEx->HID =3D=3D 0) { > UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); > -- > 2.18.0.windows.1