* [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx @ 2018-11-08 13:49 Dandan Bi 2018-11-08 13:56 ` Gao, Liming 0 siblings, 1 reply; 4+ messages in thread From: Dandan Bi @ 2018-11-08 13:49 UTC (permalink / raw) To: edk2-devel; +Cc: Ruiyu Ni, Michael D Kinney, Liming Gao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312 Text format for AcpiEx device path in UEFI Spec: AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR) AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only) When convert device path to text for ACPI device path, current code check AllowShortcuts parameter to convert the device path to DisplayOnly text format(shorter text representation) by mistake. It should check DisplayOnly parameter. This commit is to fix this issue. Cc: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <liming.gao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi <dandan.bi@intel.com> --- MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c index cdcdb3623a..97d279eeb2 100644 --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c @@ -495,11 +495,11 @@ DevPathToTextAcpiEx ( CIDText, UIDStr ); } } else { - if (AllowShortcuts) { + if (DisplayOnly) { // // display only // if (AcpiEx->HID == 0) { UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); -- 2.18.0.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx 2018-11-08 13:49 [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx Dandan Bi @ 2018-11-08 13:56 ` Gao, Liming 2018-11-09 3:34 ` Bi, Dandan 0 siblings, 1 reply; 4+ messages in thread From: Gao, Liming @ 2018-11-08 13:56 UTC (permalink / raw) To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Kinney, Michael D Reviewed-by: Liming Gao <liming.gao@intel.com> > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, November 8, 2018 9:50 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> > Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312 > > Text format for AcpiEx device path in UEFI Spec: > AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR) > AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only) > > When convert device path to text for ACPI device path, > current code check AllowShortcuts parameter to convert > the device path to DisplayOnly text format(shorter text > representation) by mistake. > It should check DisplayOnly parameter. > > This commit is to fix this issue. > > Cc: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi <dandan.bi@intel.com> > --- > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > index cdcdb3623a..97d279eeb2 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > @@ -495,11 +495,11 @@ DevPathToTextAcpiEx ( > CIDText, > UIDStr > ); > } > } else { > - if (AllowShortcuts) { > + if (DisplayOnly) { > // > // display only > // > if (AcpiEx->HID == 0) { > UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); > -- > 2.18.0.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx 2018-11-08 13:56 ` Gao, Liming @ 2018-11-09 3:34 ` Bi, Dandan 2018-11-09 8:01 ` Laszlo Ersek 0 siblings, 1 reply; 4+ messages in thread From: Bi, Dandan @ 2018-11-09 3:34 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org, afish@apple.com, Laszlo Ersek, Leif Lindholm Cc: Ni, Ruiyu, Kinney, Michael D, Bi, Dandan Hi Stewards and package maintainers: Since this is a clear bug. And the risk for this release is small. So I plan to push this patch before edk2-stable201811 tag is created. If you have any concern, please raise here. Thanks, Dandan > -----Original Message----- > From: Gao, Liming > Sent: Thursday, November 8, 2018 9:56 PM > To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: RE: [patch] MdePkg: Fix incorrect check for DisplayOnly text format > in AcpiEx > > Reviewed-by: Liming Gao <liming.gao@intel.com> > > > -----Original Message----- > > From: Bi, Dandan > > Sent: Thursday, November 8, 2018 9:50 PM > > To: edk2-devel@lists.01.org > > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> > > Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text > > format in AcpiEx > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312 > > > > Text format for AcpiEx device path in UEFI Spec: > > AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR) > > AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only) > > > > When convert device path to text for ACPI device path, current code > > check AllowShortcuts parameter to convert the device path to > > DisplayOnly text format(shorter text > > representation) by mistake. > > It should check DisplayOnly parameter. > > > > This commit is to fix this issue. > > > > Cc: Ruiyu Ni <ruiyu.ni@intel.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <liming.gao@intel.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Dandan Bi <dandan.bi@intel.com> > > --- > > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > index cdcdb3623a..97d279eeb2 100644 > > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > @@ -495,11 +495,11 @@ DevPathToTextAcpiEx ( > > CIDText, > > UIDStr > > ); > > } > > } else { > > - if (AllowShortcuts) { > > + if (DisplayOnly) { > > // > > // display only > > // > > if (AcpiEx->HID == 0) { > > UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); > > -- > > 2.18.0.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx 2018-11-09 3:34 ` Bi, Dandan @ 2018-11-09 8:01 ` Laszlo Ersek 0 siblings, 0 replies; 4+ messages in thread From: Laszlo Ersek @ 2018-11-09 8:01 UTC (permalink / raw) To: Bi, Dandan, Gao, Liming, edk2-devel@lists.01.org, afish@apple.com, Leif Lindholm Cc: Ni, Ruiyu, Kinney, Michael D On 11/09/18 04:34, Bi, Dandan wrote: > Hi Stewards and package maintainers: > > Since this is a clear bug. And the risk for this release is small. > So I plan to push this patch before edk2-stable201811 tag is created. I agree, this is a bugfix, not a feature patch. Thanks, Laszlo > If you have any concern, please raise here. > > > Thanks, > Dandan > >> -----Original Message----- >> From: Gao, Liming >> Sent: Thursday, November 8, 2018 9:56 PM >> To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org >> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Kinney, Michael D >> <michael.d.kinney@intel.com> >> Subject: RE: [patch] MdePkg: Fix incorrect check for DisplayOnly text format >> in AcpiEx >> >> Reviewed-by: Liming Gao <liming.gao@intel.com> >> >>> -----Original Message----- >>> From: Bi, Dandan >>> Sent: Thursday, November 8, 2018 9:50 PM >>> To: edk2-devel@lists.01.org >>> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Kinney, Michael D >>> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> >>> Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text >>> format in AcpiEx >>> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312 >>> >>> Text format for AcpiEx device path in UEFI Spec: >>> AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR) >>> AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only) >>> >>> When convert device path to text for ACPI device path, current code >>> check AllowShortcuts parameter to convert the device path to >>> DisplayOnly text format(shorter text >>> representation) by mistake. >>> It should check DisplayOnly parameter. >>> >>> This commit is to fix this issue. >>> >>> Cc: Ruiyu Ni <ruiyu.ni@intel.com> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com> >>> Cc: Liming Gao <liming.gao@intel.com> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Dandan Bi <dandan.bi@intel.com> >>> --- >>> MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> index cdcdb3623a..97d279eeb2 100644 >>> --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> @@ -495,11 +495,11 @@ DevPathToTextAcpiEx ( >>> CIDText, >>> UIDStr >>> ); >>> } >>> } else { >>> - if (AllowShortcuts) { >>> + if (DisplayOnly) { >>> // >>> // display only >>> // >>> if (AcpiEx->HID == 0) { >>> UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); >>> -- >>> 2.18.0.windows.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-09 8:01 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-08 13:49 [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx Dandan Bi 2018-11-08 13:56 ` Gao, Liming 2018-11-09 3:34 ` Bi, Dandan 2018-11-09 8:01 ` Laszlo Ersek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox