From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7748521A07A80 for ; Thu, 8 Nov 2018 16:19:09 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2018 16:19:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,481,1534834800"; d="scan'208";a="107107311" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 08 Nov 2018 16:19:08 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 8 Nov 2018 16:19:07 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.84]) with mapi id 14.03.0415.000; Fri, 9 Nov 2018 08:19:06 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "Zeng, Star" CC: "Bi, Dandan" , "edk2-devel@lists.01.org" , "Wu, Hao A" , "Dong, Eric" , "Gao, Liming" Thread-Topic: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos Thread-Index: AQHUdqmiCNK2ekw/m0KKS894fU9KF6VEjAgAgAEhQ4CAAOarIA== Date: Fri, 9 Nov 2018 00:19:06 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E367B56@SHSMSX104.ccr.corp.intel.com> References: <20181107145311.42488-1-dandan.bi@intel.com> <0C09AFA07DD0434D9E2A0C6AEB048310401EC2D7@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 00:19:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 QXJkOg0KICBUaGlzIGlzIGEgc21hbGwgZml4LiBBbmQsIHRoaXMgcGF0Y2ggaXMgc2VudCBiZWZv cmUgdGhlIGhhcmQgZnJlZXplLiBJdCBpcyB0aGUgbG93IHJpc2sgZm9yIHRoaXMgcmVsZWFzZS4g U28sIEkgcHVzaCBpdC4gDQoNClRoYW5rcw0KTGltaW5nDQo+LS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCj5Gcm9tOiBBcmQgQmllc2hldXZlbCBbbWFpbHRvOmFyZC5iaWVzaGV1dmVsQGxpbmFy by5vcmddDQo+U2VudDogRnJpZGF5LCBOb3ZlbWJlciAwOSwgMjAxOCAyOjI1IEFNDQo+VG86IFpl bmcsIFN0YXIgPHN0YXIuemVuZ0BpbnRlbC5jb20+DQo+Q2M6IEJpLCBEYW5kYW4gPGRhbmRhbi5i aUBpbnRlbC5jb20+OyBlZGsyLWRldmVsQGxpc3RzLjAxLm9yZzsgV3UsIEhhbyBBDQo+PGhhby5h Lnd1QGludGVsLmNvbT47IERvbmcsIEVyaWMgPGVyaWMuZG9uZ0BpbnRlbC5jb20+OyBHYW8sIExp bWluZw0KPjxsaW1pbmcuZ2FvQGludGVsLmNvbT4NCj5TdWJqZWN0OiBSZTogW2VkazJdIFtwYXRj aF0gTWRlTW9kdWxlUGtnL0Rpc3BsYXlFbmdpbmU6IFJlbW92ZSB1c2VsZXNzDQo+TlVMTCBwdHIg Y2hlY2sgZm9yIE5ld1Bvcw0KPg0KPk9uIDggTm92ZW1iZXIgMjAxOCBhdCAwMjowOSwgWmVuZywg U3RhciA8c3Rhci56ZW5nQGludGVsLmNvbT4gd3JvdGU6DQo+PiBSZXZpZXdlZC1ieTogU3RhciBa ZW5nIDxzdGFyLnplbmdAaW50ZWwuY29tPg0KPj4NCj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tDQo+PiBGcm9tOiBCaSwgRGFuZGFuDQo+PiBTZW50OiBXZWRuZXNkYXksIE5vdmVtYmVyIDcs IDIwMTggMTA6NTMgUE0NCj4+IFRvOiBlZGsyLWRldmVsQGxpc3RzLjAxLm9yZw0KPj4gQ2M6IEdh bywgTGltaW5nIDxsaW1pbmcuZ2FvQGludGVsLmNvbT47IERvbmcsIEVyaWMgPGVyaWMuZG9uZ0Bp bnRlbC5jb20+Ow0KPlplbmcsIFN0YXIgPHN0YXIuemVuZ0BpbnRlbC5jb20+OyBXdSwgSGFvIEEg PGhhby5hLnd1QGludGVsLmNvbT4NCj4+IFN1YmplY3Q6IFtwYXRjaF0gTWRlTW9kdWxlUGtnL0Rp c3BsYXlFbmdpbmU6IFJlbW92ZSB1c2VsZXNzIE5VTEwgcHRyDQo+Y2hlY2sgZm9yIE5ld1Bvcw0K Pj4NCj4+IFJFRjogaHR0cHM6Ly9idWd6aWxsYS50aWFub2NvcmUub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzA2DQo+Pg0KPj4gSW4gZnVuY3Rpb24gVWlEaXNwbGF5TWVudSwgdGhlIE5ld1BvcyBwdHIg d2hpY2ggdXNlZCB0byBwb2ludCB0byB0aGUNCj5oaWdobGlnaHQgbWVudSBlbnRyeS4gSXQgd2ls bCBhbHdheXMgcG9pbnQgdG8gdGhlIG1lbnUgZW50cnkgd2hpY2ggbmVlZCB0byBiZQ0KPmhpZ2hs aWdodGVkIG9yIHRoZSBnTWVudU9wdGlvbiBtZW51IGlmIHRoZSBoaWdobGlnaHQgbWVudSBpcyBu b3QgZm91bmQuDQo+PiBTbyB3ZSBjYW4gcmVtb3ZlIHRoZSBOVUxMIHB0ciBjaGVjayBmb3IgTmV3 UG9zIGluIHRoaXMgZnVuY3Rpb24uDQo+PiBBbmQgYWRkIHRoZSBBU1NFUlQgY29kZSB0byBhdm9p ZCBpZiBhbnkgZmFsc2UgcG9zaXRpdmUgcmVwb3J0cyBvZiBOVUxMDQo+cG9pbnRlciBkZXJlZmVy ZW5jZSBpc3N1ZSByYWlzZWQgZnJvbSBzdGF0aWMgYW5hbHlzaXMuDQo+Pg0KPj4gQ2M6IExpbWlu ZyBHYW8gPGxpbWluZy5nYW9AaW50ZWwuY29tPg0KPj4gQ2M6IEVyaWMgRG9uZyA8ZXJpYy5kb25n QGludGVsLmNvbT4NCj4+IENjOiBTdGFyIFplbmcgPHN0YXIuemVuZ0BpbnRlbC5jb20+DQo+PiBD YzogSGFvIFd1IDxoYW8uYS53dUBpbnRlbC5jb20+DQo+PiBDb250cmlidXRlZC11bmRlcjogVGlh bm9Db3JlIENvbnRyaWJ1dGlvbiBBZ3JlZW1lbnQgMS4xDQo+PiBTaWduZWQtb2ZmLWJ5OiBEYW5k YW4gQmkgPGRhbmRhbi5iaUBpbnRlbC5jb20+DQo+DQo+V2h5IHdhcyB0aGlzIHBhdGNoIG1lcmdl ZCB0b2RheT8gU3VyZWx5LCB0aGlzIGRvZXNuJ3QgbWVldCB0aGUgaGFyZA0KPmZyZWV6ZSByZXF1 aXJlbWVudHMgPw0KPg0KPj4gLS0tDQo+PiAgTWRlTW9kdWxlUGtnL1VuaXZlcnNhbC9EaXNwbGF5 RW5naW5lRHhlL0Zvcm1EaXNwbGF5LmMgfCAzICsrLQ0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvTWRlTW9kdWxl UGtnL1VuaXZlcnNhbC9EaXNwbGF5RW5naW5lRHhlL0Zvcm1EaXNwbGF5LmMNCj5iL01kZU1vZHVs ZVBrZy9Vbml2ZXJzYWwvRGlzcGxheUVuZ2luZUR4ZS9Gb3JtRGlzcGxheS5jDQo+PiBpbmRleCA3 MzkwZjk1NGI2Li40NGYwODdmZTAxIDEwMDY0NA0KPj4gLS0tIGEvTWRlTW9kdWxlUGtnL1VuaXZl cnNhbC9EaXNwbGF5RW5naW5lRHhlL0Zvcm1EaXNwbGF5LmMNCj4+ICsrKyBiL01kZU1vZHVsZVBr Zy9Vbml2ZXJzYWwvRGlzcGxheUVuZ2luZUR4ZS9Gb3JtRGlzcGxheS5jDQo+PiBAQCAtMjg4MCwx MCArMjg4MCwxMSBAQCBVaURpc3BsYXlNZW51ICgNCj4+ICAgICAgICAvLyAgICAgICAgICAgICBN ZW51T3B0aW9uIGlzIHNldCB0byBOVUxMIGluIFJlcGFpbnQNCj4+ICAgICAgICAvLyBOZXdQb3M6 ICAgICBDdXJyZW50IG1lbnUgb3B0aW9uIHRoYXQgbmVlZCB0byBoaWxpZ2h0DQo+PiAgICAgICAg Ly8NCj4+ICAgICAgICBDb250cm9sRmxhZyA9IENmVXBkYXRlSGVscFN0cmluZzsNCj4+DQo+PiAr ICAgICAgQVNTRVJUIChOZXdQb3MgIT0gTlVMTCk7DQo+PiAgICAgICAgVXBkYXRlSGlnaGxpZ2h0 TWVudUluZm8oTmV3UG9zLCBUb3BPZlNjcmVlbiwgU2tpcFZhbHVlKTsNCj4+DQo+PiAgICAgICAg aWYgKFNraXBIaWdoTGlnaHQpIHsNCj4+ICAgICAgICAgIFNraXBIaWdoTGlnaHQgPSBGQUxTRTsN Cj4+ICAgICAgICAgIE1lbnVPcHRpb24gICAgPSBTYXZlZE1lbnVPcHRpb247DQo+PiBAQCAtMjkw OCwxMSArMjkwOSwxMSBAQCBVaURpc3BsYXlNZW51ICgNCj4+ICAgICAgICAgIFRlbXAyID0gU2tp cFZhbHVlOw0KPj4gICAgICAgIH0gZWxzZSB7DQo+PiAgICAgICAgICBUZW1wMiA9IDA7DQo+PiAg ICAgICAgfQ0KPj4NCj4+IC0gICAgICBpZiAoTmV3UG9zICE9IE5VTEwgJiYgKE1lbnVPcHRpb24g PT0gTlVMTCB8fCBOZXdQb3MgIT0NCj4mTWVudU9wdGlvbi0+TGluaykpIHsNCj4+ICsgICAgICBp ZiAoTWVudU9wdGlvbiA9PSBOVUxMIHx8IE5ld1BvcyAhPSAmTWVudU9wdGlvbi0+TGluaykgew0K Pj4gICAgICAgICAgaWYgKE1lbnVPcHRpb24gIT0gTlVMTCkgew0KPj4gICAgICAgICAgICAvLw0K Pj4gICAgICAgICAgICAvLyBSZW1vdmUgdGhlIG9sZCBoaWdobGlnaHQgbWVudS4NCj4+ICAgICAg ICAgICAgLy8NCj4+ICAgICAgICAgICAgU3RhdHVzID0gRGlzcGxheU9uZU1lbnUgKE1lbnVPcHRp b24sDQo+PiAtLQ0KPj4gMi4xOC4wLndpbmRvd3MuMQ0KPj4NCj4+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+PiBlZGsyLWRldmVsIG1haWxpbmcgbGlz dA0KPj4gZWRrMi1kZXZlbEBsaXN0cy4wMS5vcmcNCj4+IGh0dHBzOi8vbGlzdHMuMDEub3JnL21h aWxtYW4vbGlzdGluZm8vZWRrMi1kZXZlbA0K