From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 419582118D948 for ; Tue, 13 Nov 2018 16:34:47 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 16:34:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,230,1539673200"; d="scan'208";a="108341561" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 13 Nov 2018 16:34:46 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 13 Nov 2018 16:34:46 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 13 Nov 2018 16:34:45 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Wed, 14 Nov 2018 08:34:43 +0800 From: "Gao, Liming" To: Leif Lindholm CC: "Zhu, Yonghong" , "edk2-devel@lists.01.org" , "Laszlo Ersek (lersek@redhat.com)" , "Kinney, Michael D" , "afish@apple.com" Thread-Topic: [edk2] [Patch 0/3] Fix UEFI and Tiano Decompression logic issue Thread-Index: AQHUd772ueEsON9b60eF8yBDy4QVpKVIMDOAgADgTqCAAOt3AIAEd7XA Date: Wed, 14 Nov 2018 00:34:43 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3698AE@SHSMSX104.ccr.corp.intel.com> References: <1541721496-13332-1-git-send-email-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3686EA@SHSMSX104.ccr.corp.intel.com> <20181111121926.q4qkof54nt737plp@bivouac.eciton.net> In-Reply-To: <20181111121926.q4qkof54nt737plp@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/3] Fix UEFI and Tiano Decompression logic issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 00:34:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: Thanks for your comments. I add more detail in https://bugzilla.tianocore.= org/show_bug.cgi?id=3D1317. I think we can add more information in this BZ.= =20 Thanks Liming >-----Original Message----- >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >Sent: Sunday, November 11, 2018 8:19 PM >To: Gao, Liming >Cc: Zhu, Yonghong ; edk2-devel@lists.01.org; >Laszlo Ersek (lersek@redhat.com) ; Kinney, Michael D >; afish@apple.com >Subject: Re: [edk2] [Patch 0/3] Fix UEFI and Tiano Decompression logic iss= ue > >Hi Liming, > >I have no issue with a fix for this issue going in during the hard >freeze, but neither the commit messages nor the cover letter contain >information of what problem was caused by the bug. > >It also does not say anything about the likelihood of hitting this >bug, or what criteria need to be met. Nor does the bugzilla entry. > >The bugzilla entry talks only about the TianoCompress utility, but we >the patches also modify runtime code. > >Detail in commit messages are always important, but since this >modifies the behaviour of CVE fixes, there needs to be no room left >(for reviewers) to wonder whether the bugs have been sufficiently >understood and investigated. > >Regards, > >Leif > >On Sat, Nov 10, 2018 at 02:18:51PM +0000, Gao, Liming wrote: >> Hi, all >> This patch fixes the Uefi and Tiano decompression issue. I will >> push it for edk2-stable201811 tag. If you have any comments, >> please let me know. >> >> Thanks >> Liming >> > -----Original Message----- >> > From: Zhu, Yonghong >> > Sent: Saturday, November 10, 2018 4:54 PM >> > To: Gao, Liming ; edk2-devel@lists.01.org >> > Cc: Zhu, Yonghong >> > Subject: RE: [edk2] [Patch 0/3] Fix UEFI and Tiano Decompression logic >issue >> > >> > Reviewed-by: Yonghong Zhu >> > >> > Best Regards, >> > Zhu Yonghong >> > >> > -----Original Message----- >> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Liming Gao >> > Sent: Friday, November 09, 2018 7:58 AM >> > To: edk2-devel@lists.01.org >> > Subject: [edk2] [Patch 0/3] Fix UEFI and Tiano Decompression logic iss= ue >> > >> > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1317 >> > >> > This is a regression issue caused by previous change with more checker= s in >UefiDecompress. In Decode() function, once mOutBuf is fully >> > filled, Decode() should return. Current logic misses the checker of >mOutBuf after while() loop. >> > >> > Liming Gao (3): >> > BaseTools: Fix UEFI and Tiano Decompression logic issue >> > MdePkg BaseUefiDecompressLib: Fix UEFI Decompression logic issue >> > IntelFrameworkModulePkg: Fix UEFI and Tiano Decompression logic issu= e >> > >> > BaseTools/Source/C/Common/Decompress.c >| 6 ++++++ >> > BaseTools/Source/C/TianoCompress/TianoCompress.c >| 6 ++++++ >> > >IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/Bas >eUefiTianoCustomDecompressLib.c | 6 ++++++ >> > MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c >| 6 ++++++ >> > 4 files changed, 24 insertions(+) >> > >> > -- >> > 2.16.2.windows.1 >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > edk2-devel@lists.01.org >> > https://lists.01.org/mailman/listinfo/edk2-devel