From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 681C321193094 for ; Mon, 19 Nov 2018 19:51:15 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2018 19:51:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,255,1539673200"; d="scan'208";a="281389005" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 19 Nov 2018 19:51:14 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 19 Nov 2018 19:51:14 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 19 Nov 2018 19:51:13 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.161]) with mapi id 14.03.0415.000; Tue, 20 Nov 2018 11:51:12 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [patch] MdePkg: Check input Ptrs in GetSectionFromAnyFvByFileType Thread-Index: AQHUf6zaGmkCMMalsU2DdnlntTT4taVYCPLg Date: Tue, 20 Nov 2018 03:51:10 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E36EF40@SHSMSX104.ccr.corp.intel.com> References: <20181119020833.22748-1-dandan.bi@intel.com> <20181119020833.22748-2-dandan.bi@intel.com> In-Reply-To: <20181119020833.22748-2-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzZkOTZmMzgtOGYyMC00YmY0LThhNjItMzY3NTA0ZDA5ZmZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUmlHU2JcL1dlSERMNFJkSEFoMHFQQWpqOGhmV1lDa214b0JxcXJ2aTB0M1VzZm9lTFNnb3FhSkxFdU9tNitGc2kifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdePkg: Check input Ptrs in GetSectionFromAnyFvByFileType X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 03:51:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Bi, Dandan > Sent: Monday, November 19, 2018 10:09 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > Subject: [patch] MdePkg: Check input Ptrs in GetSectionFromAnyFvByFileTyp= e >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1337 >=20 > In function GetSectionFromAnyFvByFileType, the input parameter "Buffer" > and "size" should not be NULL, so add ASSERT here to avoid any checker > report that the NULL pointer may be used. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c b/MdePkg/Libr= ary/DxeServicesLib/DxeServicesLib.c > index d4f366425f..e78d51cb92 100644 > --- a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c > +++ b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c > @@ -251,10 +251,13 @@ GetSectionFromAnyFvByFileType ( > UINTN Key; > EFI_GUID NameGuid; > EFI_FV_FILE_ATTRIBUTES Attributes; > EFI_FIRMWARE_VOLUME2_PROTOCOL *Fv; >=20 > + ASSERT (Buffer !=3D NULL); > + ASSERT (Size !=3D NULL); > + > // > // Locate all available FVs. > // > HandleBuffer =3D NULL; > Status =3D gBS->LocateHandleBuffer ( > -- > 2.18.0.windows.1