* [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h @ 2018-11-20 7:03 Gary Lin 2018-11-20 8:51 ` Laszlo Ersek 0 siblings, 1 reply; 6+ messages in thread From: Gary Lin @ 2018-11-20 7:03 UTC (permalink / raw) To: edk2-devel; +Cc: Michael D Kinney, Liming Gao The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing square bracket mistakenly. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <liming.gao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Gary Lin <glin@suse.com> --- MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h index b2276b7d64d5..c66566e58647 100644 --- a/MdePkg/Include/IndustryStandard/Acpi61.h +++ b/MdePkg/Include/IndustryStandard/Acpi61.h @@ -1400,7 +1400,7 @@ typedef struct { #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} -#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} +#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} typedef struct { UINT16 Type; UINT16 Length; diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h index 730365b521d1..11ce1c16fb91 100644 --- a/MdePkg/Include/IndustryStandard/Acpi62.h +++ b/MdePkg/Include/IndustryStandard/Acpi62.h @@ -1512,7 +1512,7 @@ typedef struct { #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} -#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} +#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} typedef struct { UINT16 Type; UINT16 Length; -- 2.19.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h 2018-11-20 7:03 [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h Gary Lin @ 2018-11-20 8:51 ` Laszlo Ersek 2018-11-20 14:37 ` Gao, Liming 0 siblings, 1 reply; 6+ messages in thread From: Laszlo Ersek @ 2018-11-20 8:51 UTC (permalink / raw) To: Gary Lin, edk2-devel; +Cc: Michael D Kinney, Liming Gao On 11/20/18 08:03, Gary Lin wrote: > The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing > square bracket mistakenly. > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gary Lin <glin@suse.com> > --- > MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- > MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Good catch! Reviewed-by: Laszlo Ersek <lersek@redhat.com> Thanks Laszlo > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h > index b2276b7d64d5..c66566e58647 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > @@ -1400,7 +1400,7 @@ typedef struct { > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} > -#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} > +#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} > typedef struct { > UINT16 Type; > UINT16 Length; > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h > index 730365b521d1..11ce1c16fb91 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -1512,7 +1512,7 @@ typedef struct { > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} > -#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} > +#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} > typedef struct { > UINT16 Type; > UINT16 Length; > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h 2018-11-20 8:51 ` Laszlo Ersek @ 2018-11-20 14:37 ` Gao, Liming 2018-11-21 1:50 ` Zeng, Star 2018-11-27 1:47 ` Gary Lin 0 siblings, 2 replies; 6+ messages in thread From: Gao, Liming @ 2018-11-20 14:37 UTC (permalink / raw) To: Laszlo Ersek, Gary Lin, edk2-devel@lists.01.org; +Cc: Kinney, Michael D Reviewed-by: Liming Gao <liming.gao@intel.com> > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Tuesday, November 20, 2018 4:52 PM > To: Gary Lin <glin@suse.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> > Subject: Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h > > On 11/20/18 08:03, Gary Lin wrote: > > The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing > > square bracket mistakenly. > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <liming.gao@intel.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Gary Lin <glin@suse.com> > > --- > > MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- > > MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Good catch! > > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > > Thanks > Laszlo > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h > > index b2276b7d64d5..c66566e58647 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > > @@ -1400,7 +1400,7 @@ typedef struct { > > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, > { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} > > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, > { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} > > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, > { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} > > -#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} > > +#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} > > typedef struct { > > UINT16 Type; > > UINT16 Length; > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h > > index 730365b521d1..11ce1c16fb91 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > > @@ -1512,7 +1512,7 @@ typedef struct { > > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, > { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} > > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, > { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} > > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, > { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} > > -#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} > > +#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} > > typedef struct { > > UINT16 Type; > > UINT16 Length; > > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h 2018-11-20 14:37 ` Gao, Liming @ 2018-11-21 1:50 ` Zeng, Star 2018-11-27 1:47 ` Gary Lin 1 sibling, 0 replies; 6+ messages in thread From: Zeng, Star @ 2018-11-21 1:50 UTC (permalink / raw) To: Gao, Liming, Laszlo Ersek, Gary Lin, edk2-devel@lists.01.org Cc: Kinney, Michael D, star.zeng On 2018/11/20 22:37, Gao, Liming wrote: > Reviewed-by: Liming Gao <liming.gao@intel.com> > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek >> Sent: Tuesday, November 20, 2018 4:52 PM >> To: Gary Lin <glin@suse.com>; edk2-devel@lists.01.org >> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> >> Subject: Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h >> >> On 11/20/18 08:03, Gary Lin wrote: >>> The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing >>> square bracket mistakenly. >>> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com> >>> Cc: Liming Gao <liming.gao@intel.com> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Gary Lin <glin@suse.com> >>> --- >>> MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- >>> MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> Good catch! >> >> Reviewed-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Star Zeng <star.zeng@intel.com> Thanks, Star >> >> Thanks >> Laszlo >> >>> diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h >>> index b2276b7d64d5..c66566e58647 100644 >>> --- a/MdePkg/Include/IndustryStandard/Acpi61.h >>> +++ b/MdePkg/Include/IndustryStandard/Acpi61.h >>> @@ -1400,7 +1400,7 @@ typedef struct { >>> #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, >> { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} >>> #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, >> { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} >>> #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, >> { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} >>> -#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} >>> +#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} >>> typedef struct { >>> UINT16 Type; >>> UINT16 Length; >>> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h >>> index 730365b521d1..11ce1c16fb91 100644 >>> --- a/MdePkg/Include/IndustryStandard/Acpi62.h >>> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h >>> @@ -1512,7 +1512,7 @@ typedef struct { >>> #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, >> { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} >>> #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, >> { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} >>> #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, >> { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} >>> -#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} >>> +#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} >>> typedef struct { >>> UINT16 Type; >>> UINT16 Length; >>> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h 2018-11-20 14:37 ` Gao, Liming 2018-11-21 1:50 ` Zeng, Star @ 2018-11-27 1:47 ` Gary Lin 2018-11-27 3:19 ` Gao, Liming 1 sibling, 1 reply; 6+ messages in thread From: Gary Lin @ 2018-11-27 1:47 UTC (permalink / raw) To: Gao, Liming; +Cc: Laszlo Ersek, edk2-devel@lists.01.org, Kinney, Michael D On Tue, Nov 20, 2018 at 02:37:44PM +0000, Gao, Liming wrote: > Reviewed-by: Liming Gao <liming.gao@intel.com> > Hi Liming, Would you mind to help to push to fix into the git repo? Thanks, Gary Lin > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek > > Sent: Tuesday, November 20, 2018 4:52 PM > > To: Gary Lin <glin@suse.com>; edk2-devel@lists.01.org > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> > > Subject: Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h > > > > On 11/20/18 08:03, Gary Lin wrote: > > > The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing > > > square bracket mistakenly. > > > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > > Cc: Liming Gao <liming.gao@intel.com> > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Gary Lin <glin@suse.com> > > > --- > > > MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- > > > MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > Good catch! > > > > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > > > > Thanks > > Laszlo > > > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h > > > index b2276b7d64d5..c66566e58647 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > > > @@ -1400,7 +1400,7 @@ typedef struct { > > > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, > > { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} > > > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, > > { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} > > > #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, > > { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} > > > -#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, > > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} > > > +#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, > > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} > > > typedef struct { > > > UINT16 Type; > > > UINT16 Length; > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h > > > index 730365b521d1..11ce1c16fb91 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > > > @@ -1512,7 +1512,7 @@ typedef struct { > > > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, > > { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} > > > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, > > { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} > > > #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, > > { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} > > > -#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, > > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} > > > +#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, > > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} > > > typedef struct { > > > UINT16 Type; > > > UINT16 Length; > > > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h 2018-11-27 1:47 ` Gary Lin @ 2018-11-27 3:19 ` Gao, Liming 0 siblings, 0 replies; 6+ messages in thread From: Gao, Liming @ 2018-11-27 3:19 UTC (permalink / raw) To: Gary Lin; +Cc: Laszlo Ersek, edk2-devel@lists.01.org, Kinney, Michael D Done at 385c0bf55a3e26dd1d3b5671f4ee69cd3f829baf. >-----Original Message----- >From: Gary Lin [mailto:glin@suse.com] >Sent: Tuesday, November 27, 2018 9:48 AM >To: Gao, Liming <liming.gao@intel.com> >Cc: Laszlo Ersek <lersek@redhat.com>; edk2-devel@lists.01.org; Kinney, >Michael D <michael.d.kinney@intel.com> >Subject: Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and >Acpi62.h > >On Tue, Nov 20, 2018 at 02:37:44PM +0000, Gao, Liming wrote: >> Reviewed-by: Liming Gao <liming.gao@intel.com> >> >Hi Liming, > >Would you mind to help to push to fix into the git repo? > >Thanks, > >Gary Lin > >> > -----Original Message----- >> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Laszlo Ersek >> > Sent: Tuesday, November 20, 2018 4:52 PM >> > To: Gary Lin <glin@suse.com>; edk2-devel@lists.01.org >> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming ><liming.gao@intel.com> >> > Subject: Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h >and Acpi62.h >> > >> > On 11/20/18 08:03, Gary Lin wrote: >> > > The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing >> > > square bracket mistakenly. >> > > >> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> >> > > Cc: Liming Gao <liming.gao@intel.com> >> > > Contributed-under: TianoCore Contribution Agreement 1.1 >> > > Signed-off-by: Gary Lin <glin@suse.com> >> > > --- >> > > MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- >> > > MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- >> > > 2 files changed, 2 insertions(+), 2 deletions(-) >> > >> > Good catch! >> > >> > Reviewed-by: Laszlo Ersek <lersek@redhat.com> >> > >> > Thanks >> > Laszlo >> > >> > > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h >b/MdePkg/Include/IndustryStandard/Acpi61.h >> > > index b2276b7d64d5..c66566e58647 100644 >> > > --- a/MdePkg/Include/IndustryStandard/Acpi61.h >> > > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h >> > > @@ -1400,7 +1400,7 @@ typedef struct { >> > > #define >EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGIO >N_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, >> > { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} >> > > #define >EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION >_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, >> > { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} >> > > #define >EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGIO >N_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, >> > { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} >> > > -#define >EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION >_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} >> > > +#define >EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION >_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} >> > > typedef struct { >> > > UINT16 Type; >> > > UINT16 Length; >> > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h >b/MdePkg/Include/IndustryStandard/Acpi62.h >> > > index 730365b521d1..11ce1c16fb91 100644 >> > > --- a/MdePkg/Include/IndustryStandard/Acpi62.h >> > > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h >> > > @@ -1512,7 +1512,7 @@ typedef struct { >> > > #define >EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGIO >N_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, >> > { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} >> > > #define >EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION >_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, >> > { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} >> > > #define >EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGIO >N_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, >> > { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} >> > > -#define >EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION >_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} >> > > +#define >EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION >_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> > { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} >> > > typedef struct { >> > > UINT16 Type; >> > > UINT16 Length; >> > > >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > edk2-devel@lists.01.org >> > https://lists.01.org/mailman/listinfo/edk2-devel >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-27 3:19 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-20 7:03 [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h Gary Lin 2018-11-20 8:51 ` Laszlo Ersek 2018-11-20 14:37 ` Gao, Liming 2018-11-21 1:50 ` Zeng, Star 2018-11-27 1:47 ` Gary Lin 2018-11-27 3:19 ` Gao, Liming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox