From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AA76A21B02822 for ; Wed, 21 Nov 2018 22:14:45 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2018 22:14:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,264,1539673200"; d="scan'208";a="275962095" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 21 Nov 2018 22:14:44 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 21 Nov 2018 22:14:44 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 21 Nov 2018 22:14:44 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Thu, 22 Nov 2018 14:14:42 +0800 From: "Gao, Liming" To: "Fu, Siyuan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Ye, Ting" , "Justen, Jordan L" , "Wu, Hao A" , "Wu, Jiaxin" , Anthony Perard , Laszlo Ersek , "Wei, David" Thread-Topic: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack Thread-Index: AQHUgiNe2T8mxBBfo027Kbjh/cfKxKVbR7kA Date: Thu, 22 Nov 2018 06:14:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E36FFDD@SHSMSX104.ccr.corp.intel.com> References: <20181122052153.89464-1-siyuan.fu@intel.com> In-Reply-To: <20181122052153.89464-1-siyuan.fu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/6] Add DSC/FDF include segment files for network stack X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 06:14:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Siyuan: Thanks for your contribution. I really like this idea to share the common= DSC/FDF between all platform DSC/FDFs. Now, FixedAtBuild PCD can also be = used in the conditional statement. Its value can be specified by build comm= and with --pcd option. So, I suggest to use FixedAtBuild PCD for network fe= ature instead of MACRO. I would like to recommend to use PCD both for the b= uild and firmware configuration. For this case, one UINT16 FixedAtBuildPcd = can be introduced in NetworkPkg.dec. Its different bit will be for the dif= ferent network features. Below is the example. Besides, I think *.dsc.inc f= iles need to include section header. If so, *.dsc.inc is the standalone dsc= file. It can easily be included in platform DSC file. Especially for libra= ry instance, the different library instance may be for the different module= type. Without section header, they can be placed into one *Libs.dsc.inc fi= le.=20 [Defines] DEFINE NETWORK_ENABLE =3D 0x1 DEFINE NETWORK_SNP_ENABLE =3D 0x2 DEFINE NETWORK_IP4_ENABLE =3D 0x4 DEFINE NETWORK_IP6_ENABLE =3D 0x8 DEFINE NETWORK_TLS_ENABLE =3D 0x10 DEFINE NETWORK_HTTP_BOOT_ENABLE =3D 0x20 DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D 0x40 DEFINE NETWORK_IPSEC_ENABLE =3D 0x80 DEFINE NETWORK_ISCSI_ENABLE =3D 0x100 DEFINE NETWORK_VLAN_ENABLE =3D 0x200 [PcdsFixedAtBuild] gEfiNetworkPkgTokenSpaceGuid.PcdNetworkFeatureMask|0xFFFF [PcdsFixedAtBuild] !if gEfiNetworkPkgTokenSpaceGuid.PcdNetworkFeatureMask & NETWORK_ALLOW_HTTP= _CONNECTIONS =3D=3D NETWORK_ALLOW_HTTP_CONNECTIONS gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE !endif Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu >Siyuan >Sent: Thursday, November 22, 2018 1:22 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Ye, Ting ; Justen, >Jordan L ; Wu, Hao A ; Wu, >Jiaxin ; Anthony Perard ; >Laszlo Ersek ; Wei, David >Subject: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for >network stack > >There is a patch to remove the redudant IP4 only iSCSI/PXE/TCP drivers >from MdeModulePkg, which has been reviewed before edk2-stable201811 >tag. >And we also have plan to move all network related libraries/modules to >NetworkPkg. In order to make these change more smoothly, a set of >fragment >files (2 for DSC and 1 for FDF) are provided for platform to enable the >network stack support, without directly reference the INF module path. > >Patch 1/6 adds centralized dsc/fdf include files to NetworkPkg, with >a set of flags for feature set enable/disable. >Patch 2~6 updates edk2 platform dsc/fdf files to use the new include >files, instead of reference the module INF. > >v2: > 1. Split the "Network.dsc.inc" in to 4 files for different sections in D= SC > file. This could provide more flexibility to platform owner to use the > include files. > 2. Clarify the OpenSSL dependency of TLS, iSCSI and IPsec enable flag. > 3. Use "!error" statement for incorrect flag value check. > 4. Update platform DSC/FDF to use the new include files. > 5. Other decoration work according to Laszlo's comments. > > > >Fu Siyuan (6): > NetworkPkg: Add DSC/FDF include segment files to NetworkPkg. > Nt32Pkg: Update DSC/FDF to use NetworkPkg's include fragment file. > ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > EmulatorPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg's include fragment > file. > > ArmVirtPkg/ArmVirt.dsc.inc | 11 +- > ArmVirtPkg/ArmVirtQemu.dsc | 46 ++----- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 28 +--- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 46 ++----- > EmulatorPkg/EmulatorPkg.dsc | 39 ++++-- > EmulatorPkg/EmulatorPkg.fdf | 10 +- > NetworkPkg/Network.fdf.inc | 69 ++++++++++ > NetworkPkg/NetworkComponents.dsc.inc | 71 ++++++++++ > NetworkPkg/NetworkDefines.dsc.inc | 138 ++++++++++++++++++++ > NetworkPkg/NetworkLibs.dsc.inc | 25 ++++ > NetworkPkg/NetworkPcds.dsc.inc | 22 ++++ > NetworkPkg/NetworkPkg.dsc | 28 +--- > Nt32Pkg/Nt32Pkg.dsc | 104 ++++----------- > Nt32Pkg/Nt32Pkg.fdf | 27 +--- > OvmfPkg/OvmfPkgIa32.dsc | 75 +++++------ > OvmfPkg/OvmfPkgIa32.fdf | 27 +--- > OvmfPkg/OvmfPkgIa32X64.dsc | 76 +++++------ > OvmfPkg/OvmfPkgIa32X64.fdf | 27 +--- > OvmfPkg/OvmfPkgX64.dsc | 75 +++++------ > OvmfPkg/OvmfPkgX64.fdf | 27 +--- > Vlv2TbltDevicePkg/PlatformPkg.fdf | 25 +--- > Vlv2TbltDevicePkg/PlatformPkgConfig.dsc | 11 +- > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 25 +--- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 52 +++----- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 52 +++----- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 52 +++----- > 26 files changed, 573 insertions(+), 615 deletions(-) > create mode 100644 NetworkPkg/Network.fdf.inc > create mode 100644 NetworkPkg/NetworkComponents.dsc.inc > create mode 100644 NetworkPkg/NetworkDefines.dsc.inc > create mode 100644 NetworkPkg/NetworkLibs.dsc.inc > create mode 100644 NetworkPkg/NetworkPcds.dsc.inc > >Cc: Jiaxin Wu >Cc: Ting Ye >Cc: Ruiyu Ni >Cc: Hao Wu >Cc: Laszlo Ersek >Cc: Ard Biesheuvel >Cc: Julien Grall >Cc: Jordan Justen >Cc: Andrew Fish >Cc: Ruiyu Ni >Cc: Anthony Perard >Cc: David Wei >Cc: Mang Guo > >-- >2.19.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel