public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: Nariman Poushin <nariman.poushin@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 1/2] Readme.md: Update instructions to fetch source
Date: Mon, 26 Nov 2018 14:11:41 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E372573@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1543237854-32562-1-git-send-email-nariman.poushin@linaro.org>

Could you add [edk2-platform] in the title? So, I know this change is for edk2-platform repo. 

And, please add Contributed-under: TianoCore Contribution Agreement 1.1 before Signed-off-by.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Nariman Poushin
> Sent: Monday, November 26, 2018 9:11 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 1/2] Readme.md: Update instructions to fetch source
> 
> Openssl is fetched as a git submodule, so make sure git clone --recursive
> is specified in the instructions to fetch a full source tree.
> 
> Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org>
> ---
>  Readme.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Readme.md b/Readme.md
> index 6ad5953..bb53c6f 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -78,7 +78,7 @@ target-specific binutils. These are included with any prepackaged GCC toolchain
>     1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building
>        platforms that need it)
>     ```
> -   $ git clone https://github.com/tianocore/edk2.git
> +   $ git clone https://github.com/tianocore/edk2.git --recursive
>     ...
>     $ git clone https://github.com/tianocore/edk2-platforms.git
>     ...
> --
> 2.7.4
> 
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  parent reply	other threads:[~2018-11-26 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 13:10 [PATCH 1/2] Readme.md: Update instructions to fetch source Nariman Poushin
2018-11-26 13:10 ` [PATCH 2/2] Platform/ARM: Add Readme.md Nariman Poushin
2018-11-26 14:11 ` Gao, Liming [this message]
2018-11-26 14:15   ` [PATCH 1/2] Readme.md: Update instructions to fetch source Nariman Poushin
2018-11-26 14:52   ` [edk2-platforms] [PATCH v2 " Nariman Poushin
2018-11-26 14:52     ` [edk2-platforms] [PATCH v3 2/2] Platform/ARM: Add Readme.md Nariman Poushin
2018-12-11 18:32     ` [edk2-platforms] [PATCH v2 1/2] Readme.md: Update instructions to fetch source Leif Lindholm
2018-12-12 15:19       ` Nariman Poushin
2018-11-26 18:41 ` [PATCH " Leif Lindholm
2018-11-27  9:34   ` [edk2-platforms] [PATCH v2 " Nariman Poushin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E372573@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox