public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v3 0/2] SortLib for UEFI SEC
@ 2018-11-08 19:04 Jeff Brasen
  2018-11-08 19:04 ` [PATCH v3 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() Jeff Brasen
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Jeff Brasen @ 2018-11-08 19:04 UTC (permalink / raw)
  To: edk2-devel; +Cc: ard.biesheuvel, leif.lindholm, Jeff Brasen

This patch series enables support for BaseSortLib in UEFI SEC Phase.
This requires the addition of the AllocateZeroPool which is implemented
in the PrePiMemoryAllocationLib.

Changelog:
v1 - Initial version
v2 - Update order of NULL check in MemoryAllocationLib
v3 - Switch to ZeroMem from SetMem

Jeff Brasen (2):
  EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()
  MdeModulePkg/BaseSortLib: Enable for all module types

 .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32 ++++++++++++++++++++++
 MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf   |  4 +--
 2 files changed, 34 insertions(+), 2 deletions(-)

-- 
2.7.4



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v3 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()
  2018-11-08 19:04 [PATCH v3 0/2] SortLib for UEFI SEC Jeff Brasen
@ 2018-11-08 19:04 ` Jeff Brasen
  2018-11-08 19:04 ` [PATCH v3 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Jeff Brasen
  2018-11-08 23:46 ` [PATCH v3 0/2] SortLib for UEFI SEC Carsey, Jaben
  2 siblings, 0 replies; 10+ messages in thread
From: Jeff Brasen @ 2018-11-08 19:04 UTC (permalink / raw)
  To: edk2-devel; +Cc: ard.biesheuvel, leif.lindholm, Jeff Brasen

This function is exposed by the MemoryAllocationLib header.
An AllocateZeroPool() function has been added to fix modules depending on
this library and this function.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c
index 0e75e23..55e9249 100644
--- a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c
+++ b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c
@@ -16,6 +16,7 @@
 #include <PiPei.h>
 
 #include <Library/BaseLib.h>
+#include <Library/BaseMemoryLib.h>
 #include <Library/PrePiLib.h>
 #include <Library/DebugLib.h>
 
@@ -195,6 +196,37 @@ AllocatePool (
 }
 
 /**
+  Allocates and zeros a buffer of type EfiBootServicesData.
+
+  Allocates the number bytes specified by AllocationSize of type EfiBootServicesData, clears the
+  buffer with zeros, and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
+  valid buffer of 0 size is returned.  If there is not enough memory remaining to satisfy the
+  request, then NULL is returned.
+
+  @param  AllocationSize        The number of bytes to allocate and zero.
+
+  @return A pointer to the allocated buffer or NULL if allocation fails.
+
+**/
+VOID *
+EFIAPI
+AllocateZeroPool (
+  IN UINTN  AllocationSize
+  )
+{
+  VOID *Buffer;
+
+  Buffer = AllocatePool (AllocationSize);
+  if (Buffer == NULL) {
+    return NULL;
+  }
+
+  ZeroMem (Buffer, AllocationSize);
+
+  return Buffer;
+}
+
+/**
   Frees a buffer that was previously allocated with one of the pool allocation functions in the
   Memory Allocation Library.
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 2/2] MdeModulePkg/BaseSortLib: Enable for all module types
  2018-11-08 19:04 [PATCH v3 0/2] SortLib for UEFI SEC Jeff Brasen
  2018-11-08 19:04 ` [PATCH v3 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() Jeff Brasen
@ 2018-11-08 19:04 ` Jeff Brasen
  2018-11-09  2:38   ` Zeng, Star
  2018-11-08 23:46 ` [PATCH v3 0/2] SortLib for UEFI SEC Carsey, Jaben
  2 siblings, 1 reply; 10+ messages in thread
From: Jeff Brasen @ 2018-11-08 19:04 UTC (permalink / raw)
  To: edk2-devel; +Cc: ard.biesheuvel, leif.lindholm, Jeff Brasen

Expose BaseSortLib for use in SEC and PEI phases.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
index f807cd7..5bd1aa1 100644
--- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
+++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
@@ -18,9 +18,9 @@
   BASE_NAME                      = BaseSortLib
   MODULE_UNI_FILE                = BaseSortLib.uni
   FILE_GUID                      = 03F3331B-F12D-494f-BF37-E55A657F2497
-  MODULE_TYPE                    = UEFI_DRIVER
+  MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
-  LIBRARY_CLASS                  = SortLib|DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION UEFI_DRIVER
+  LIBRARY_CLASS                  = SortLib
 
 #
 #  VALID_ARCHITECTURES           = IA32 X64 EBC
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 0/2] SortLib for UEFI SEC
  2018-11-08 19:04 [PATCH v3 0/2] SortLib for UEFI SEC Jeff Brasen
  2018-11-08 19:04 ` [PATCH v3 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() Jeff Brasen
  2018-11-08 19:04 ` [PATCH v3 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Jeff Brasen
@ 2018-11-08 23:46 ` Carsey, Jaben
  2018-11-28 17:17   ` Jeff Brasen
  2 siblings, 1 reply; 10+ messages in thread
From: Carsey, Jaben @ 2018-11-08 23:46 UTC (permalink / raw)
  To: Jeff Brasen, edk2-devel@lists.01.org

For the series.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jeff Brasen
> Sent: Thursday, November 08, 2018 11:04 AM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen <jbrasen@nvidia.com>
> Subject: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
> 
> This patch series enables support for BaseSortLib in UEFI SEC Phase.
> This requires the addition of the AllocateZeroPool which is implemented
> in the PrePiMemoryAllocationLib.
> 
> Changelog:
> v1 - Initial version
> v2 - Update order of NULL check in MemoryAllocationLib
> v3 - Switch to ZeroMem from SetMem
> 
> Jeff Brasen (2):
>   EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()
>   MdeModulePkg/BaseSortLib: Enable for all module types
> 
>  .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32
> ++++++++++++++++++++++
>  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf   |  4 +--
>  2 files changed, 34 insertions(+), 2 deletions(-)
> 
> --
> 2.7.4
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 2/2] MdeModulePkg/BaseSortLib: Enable for all module types
  2018-11-08 19:04 ` [PATCH v3 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Jeff Brasen
@ 2018-11-09  2:38   ` Zeng, Star
  0 siblings, 0 replies; 10+ messages in thread
From: Zeng, Star @ 2018-11-09  2:38 UTC (permalink / raw)
  To: Jeff Brasen, edk2-devel@lists.01.org; +Cc: Gao, Liming, Zeng, Star

As I remember, Liming and I have given RB to the patch at V1 series.


Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff Brasen
Sent: Friday, November 9, 2018 3:04 AM
To: edk2-devel@lists.01.org
Cc: Jeff Brasen <jbrasen@nvidia.com>
Subject: [edk2] [PATCH v3 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

Expose BaseSortLib for use in SEC and PEI phases.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
index f807cd7..5bd1aa1 100644
--- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
+++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
@@ -18,9 +18,9 @@
   BASE_NAME                      = BaseSortLib
   MODULE_UNI_FILE                = BaseSortLib.uni
   FILE_GUID                      = 03F3331B-F12D-494f-BF37-E55A657F2497
-  MODULE_TYPE                    = UEFI_DRIVER
+  MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
-  LIBRARY_CLASS                  = SortLib|DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION UEFI_DRIVER
+  LIBRARY_CLASS                  = SortLib
 
 #
 #  VALID_ARCHITECTURES           = IA32 X64 EBC
-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 0/2] SortLib for UEFI SEC
  2018-11-08 23:46 ` [PATCH v3 0/2] SortLib for UEFI SEC Carsey, Jaben
@ 2018-11-28 17:17   ` Jeff Brasen
  2018-11-28 17:55     ` Jeff Brasen
  0 siblings, 1 reply; 10+ messages in thread
From: Jeff Brasen @ 2018-11-28 17:17 UTC (permalink / raw)
  To: Carsey, Jaben, edk2-devel@lists.01.org

Any additional updates on this patch series?


Thanks,

Jeff

________________________________
From: Carsey, Jaben <jaben.carsey@intel.com>
Sent: Thursday, November 8, 2018 4:46:15 PM
To: Jeff Brasen; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC

For the series.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jeff Brasen
> Sent: Thursday, November 08, 2018 11:04 AM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen <jbrasen@nvidia.com>
> Subject: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>
> This patch series enables support for BaseSortLib in UEFI SEC Phase.
> This requires the addition of the AllocateZeroPool which is implemented
> in the PrePiMemoryAllocationLib.
>
> Changelog:
> v1 - Initial version
> v2 - Update order of NULL check in MemoryAllocationLib
> v3 - Switch to ZeroMem from SetMem
>
> Jeff Brasen (2):
>   EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()
>   MdeModulePkg/BaseSortLib: Enable for all module types
>
>  .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32
> ++++++++++++++++++++++
>  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf   |  4 +--
>  2 files changed, 34 insertions(+), 2 deletions(-)
>
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 0/2] SortLib for UEFI SEC
  2018-11-28 17:17   ` Jeff Brasen
@ 2018-11-28 17:55     ` Jeff Brasen
  2018-11-29  0:26       ` Gao, Liming
  0 siblings, 1 reply; 10+ messages in thread
From: Jeff Brasen @ 2018-11-28 17:55 UTC (permalink / raw)
  To: Carsey, Jaben, edk2-devel@lists.01.org
  Cc: Leif Lindholm, Ard Biesheuvel, Zeng, Star, eric.dong@intel.com

+cc package maintainers



________________________________
From: Jeff Brasen
Sent: Wednesday, November 28, 2018 10:17 AM
To: Carsey, Jaben; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC


Any additional updates on this patch series?


Thanks,

Jeff

________________________________
From: Carsey, Jaben <jaben.carsey@intel.com>
Sent: Thursday, November 8, 2018 4:46:15 PM
To: Jeff Brasen; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC

For the series.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jeff Brasen
> Sent: Thursday, November 08, 2018 11:04 AM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen <jbrasen@nvidia.com>
> Subject: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>
> This patch series enables support for BaseSortLib in UEFI SEC Phase.
> This requires the addition of the AllocateZeroPool which is implemented
> in the PrePiMemoryAllocationLib.
>
> Changelog:
> v1 - Initial version
> v2 - Update order of NULL check in MemoryAllocationLib
> v3 - Switch to ZeroMem from SetMem
>
> Jeff Brasen (2):
>   EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()
>   MdeModulePkg/BaseSortLib: Enable for all module types
>
>  .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32
> ++++++++++++++++++++++
>  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf   |  4 +--
>  2 files changed, 34 insertions(+), 2 deletions(-)
>
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 0/2] SortLib for UEFI SEC
  2018-11-28 17:55     ` Jeff Brasen
@ 2018-11-29  0:26       ` Gao, Liming
  2018-11-29  0:27         ` Ard Biesheuvel
  0 siblings, 1 reply; 10+ messages in thread
From: Gao, Liming @ 2018-11-29  0:26 UTC (permalink / raw)
  To: Jeff Brasen, Carsey, Jaben, edk2-devel@lists.01.org
  Cc: Dong, Eric, Zeng, Star, leif.lindholm@linaro.org,
	ard.biesheuvel@linaro.org

Jeff:
  I have given R-B on MdeModulePkg change. If EmbeddedPkg maintainer has no comments on the change in EmbeddedPkg, I will help push your patches. 

Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff
>Brasen
>Sent: Thursday, November 29, 2018 1:56 AM
>To: Carsey, Jaben <jaben.carsey@intel.com>; edk2-devel@lists.01.org
>Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>
>+cc package maintainers
>
>
>
>________________________________
>From: Jeff Brasen
>Sent: Wednesday, November 28, 2018 10:17 AM
>To: Carsey, Jaben; edk2-devel@lists.01.org
>Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>
>
>Any additional updates on this patch series?
>
>
>Thanks,
>
>Jeff
>
>________________________________
>From: Carsey, Jaben <jaben.carsey@intel.com>
>Sent: Thursday, November 8, 2018 4:46:15 PM
>To: Jeff Brasen; edk2-devel@lists.01.org
>Subject: RE: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>
>For the series.
>Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>> Jeff Brasen
>> Sent: Thursday, November 08, 2018 11:04 AM
>> To: edk2-devel@lists.01.org
>> Cc: Jeff Brasen <jbrasen@nvidia.com>
>> Subject: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>>
>> This patch series enables support for BaseSortLib in UEFI SEC Phase.
>> This requires the addition of the AllocateZeroPool which is implemented
>> in the PrePiMemoryAllocationLib.
>>
>> Changelog:
>> v1 - Initial version
>> v2 - Update order of NULL check in MemoryAllocationLib
>> v3 - Switch to ZeroMem from SetMem
>>
>> Jeff Brasen (2):
>>   EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()
>>   MdeModulePkg/BaseSortLib: Enable for all module types
>>
>>  .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32
>> ++++++++++++++++++++++
>>  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf   |  4 +--
>>  2 files changed, 34 insertions(+), 2 deletions(-)
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
>
>-----------------------------------------------------------------------------------
>This email message is for the sole use of the intended recipient(s) and may
>contain
>confidential information.  Any unauthorized review, use, disclosure or
>distribution
>is prohibited.  If you are not the intended recipient, please contact the sender
>by
>reply email and destroy all copies of the original message.
>-----------------------------------------------------------------------------------
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 0/2] SortLib for UEFI SEC
  2018-11-29  0:26       ` Gao, Liming
@ 2018-11-29  0:27         ` Ard Biesheuvel
  2018-11-29  0:38           ` Gao, Liming
  0 siblings, 1 reply; 10+ messages in thread
From: Ard Biesheuvel @ 2018-11-29  0:27 UTC (permalink / raw)
  To: Gao, Liming
  Cc: Jeff Brasen, Carsey, Jaben, edk2-devel@lists.01.org, Eric Dong,
	Zeng, Star, Leif Lindholm

On Thu, 29 Nov 2018 at 01:26, Gao, Liming <liming.gao@intel.com> wrote:
>
> Jeff:
>   I have given R-B on MdeModulePkg change. If EmbeddedPkg maintainer has no comments on the change in EmbeddedPkg, I will help push your patches.
>

Looks fine to me

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> >-----Original Message-----
> >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff
> >Brasen
> >Sent: Thursday, November 29, 2018 1:56 AM
> >To: Carsey, Jaben <jaben.carsey@intel.com>; edk2-devel@lists.01.org
> >Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
> >Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
> >
> >+cc package maintainers
> >
> >
> >
> >________________________________
> >From: Jeff Brasen
> >Sent: Wednesday, November 28, 2018 10:17 AM
> >To: Carsey, Jaben; edk2-devel@lists.01.org
> >Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
> >
> >
> >Any additional updates on this patch series?
> >
> >
> >Thanks,
> >
> >Jeff
> >
> >________________________________
> >From: Carsey, Jaben <jaben.carsey@intel.com>
> >Sent: Thursday, November 8, 2018 4:46:15 PM
> >To: Jeff Brasen; edk2-devel@lists.01.org
> >Subject: RE: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
> >
> >For the series.
> >Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >
> >> -----Original Message-----
> >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> >> Jeff Brasen
> >> Sent: Thursday, November 08, 2018 11:04 AM
> >> To: edk2-devel@lists.01.org
> >> Cc: Jeff Brasen <jbrasen@nvidia.com>
> >> Subject: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
> >>
> >> This patch series enables support for BaseSortLib in UEFI SEC Phase.
> >> This requires the addition of the AllocateZeroPool which is implemented
> >> in the PrePiMemoryAllocationLib.
> >>
> >> Changelog:
> >> v1 - Initial version
> >> v2 - Update order of NULL check in MemoryAllocationLib
> >> v3 - Switch to ZeroMem from SetMem
> >>
> >> Jeff Brasen (2):
> >>   EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()
> >>   MdeModulePkg/BaseSortLib: Enable for all module types
> >>
> >>  .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32
> >> ++++++++++++++++++++++
> >>  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf   |  4 +--
> >>  2 files changed, 34 insertions(+), 2 deletions(-)
> >>
> >> --
> >> 2.7.4
> >>
> >> _______________________________________________
> >> edk2-devel mailing list
> >> edk2-devel@lists.01.org
> >> https://lists.01.org/mailman/listinfo/edk2-devel
> >
> >-----------------------------------------------------------------------------------
> >This email message is for the sole use of the intended recipient(s) and may
> >contain
> >confidential information.  Any unauthorized review, use, disclosure or
> >distribution
> >is prohibited.  If you are not the intended recipient, please contact the sender
> >by
> >reply email and destroy all copies of the original message.
> >-----------------------------------------------------------------------------------
> >_______________________________________________
> >edk2-devel mailing list
> >edk2-devel@lists.01.org
> >https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 0/2] SortLib for UEFI SEC
  2018-11-29  0:27         ` Ard Biesheuvel
@ 2018-11-29  0:38           ` Gao, Liming
  0 siblings, 0 replies; 10+ messages in thread
From: Gao, Liming @ 2018-11-29  0:38 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: Jeff Brasen, Carsey, Jaben, edk2-devel@lists.01.org, Dong, Eric,
	Zeng, Star, Leif Lindholm

Push them at 864cba9598a934ae3f7ae744b75d60e07dbd9fe9.. ae960002fe7cb50bf5bd9741abc5a1aa92718fe6

>-----Original Message-----
>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>Sent: Thursday, November 29, 2018 8:28 AM
>To: Gao, Liming <liming.gao@intel.com>
>Cc: Jeff Brasen <jbrasen@nvidia.com>; Carsey, Jaben
><jaben.carsey@intel.com>; edk2-devel@lists.01.org; Dong, Eric
><eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>; Leif Lindholm
><leif.lindholm@linaro.org>
>Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>
>On Thu, 29 Nov 2018 at 01:26, Gao, Liming <liming.gao@intel.com> wrote:
>>
>> Jeff:
>>   I have given R-B on MdeModulePkg change. If EmbeddedPkg maintainer
>has no comments on the change in EmbeddedPkg, I will help push your
>patches.
>>
>
>Looks fine to me
>
>Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
>> >-----Original Message-----
>> >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Jeff
>> >Brasen
>> >Sent: Thursday, November 29, 2018 1:56 AM
>> >To: Carsey, Jaben <jaben.carsey@intel.com>; edk2-devel@lists.01.org
>> >Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
>> >Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>> >
>> >+cc package maintainers
>> >
>> >
>> >
>> >________________________________
>> >From: Jeff Brasen
>> >Sent: Wednesday, November 28, 2018 10:17 AM
>> >To: Carsey, Jaben; edk2-devel@lists.01.org
>> >Subject: Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>> >
>> >
>> >Any additional updates on this patch series?
>> >
>> >
>> >Thanks,
>> >
>> >Jeff
>> >
>> >________________________________
>> >From: Carsey, Jaben <jaben.carsey@intel.com>
>> >Sent: Thursday, November 8, 2018 4:46:15 PM
>> >To: Jeff Brasen; edk2-devel@lists.01.org
>> >Subject: RE: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>> >
>> >For the series.
>> >Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>> >
>> >> -----Original Message-----
>> >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
>Of
>> >> Jeff Brasen
>> >> Sent: Thursday, November 08, 2018 11:04 AM
>> >> To: edk2-devel@lists.01.org
>> >> Cc: Jeff Brasen <jbrasen@nvidia.com>
>> >> Subject: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC
>> >>
>> >> This patch series enables support for BaseSortLib in UEFI SEC Phase.
>> >> This requires the addition of the AllocateZeroPool which is implemented
>> >> in the PrePiMemoryAllocationLib.
>> >>
>> >> Changelog:
>> >> v1 - Initial version
>> >> v2 - Update order of NULL check in MemoryAllocationLib
>> >> v3 - Switch to ZeroMem from SetMem
>> >>
>> >> Jeff Brasen (2):
>> >>   EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()
>> >>   MdeModulePkg/BaseSortLib: Enable for all module types
>> >>
>> >>  .../PrePiMemoryAllocationLib/MemoryAllocationLib.c | 32
>> >> ++++++++++++++++++++++
>> >>  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf   |  4 +--
>> >>  2 files changed, 34 insertions(+), 2 deletions(-)
>> >>
>> >> --
>> >> 2.7.4
>> >>
>> >> _______________________________________________
>> >> edk2-devel mailing list
>> >> edk2-devel@lists.01.org
>> >> https://lists.01.org/mailman/listinfo/edk2-devel
>> >
>> >-----------------------------------------------------------------------------------
>> >This email message is for the sole use of the intended recipient(s) and may
>> >contain
>> >confidential information.  Any unauthorized review, use, disclosure or
>> >distribution
>> >is prohibited.  If you are not the intended recipient, please contact the
>sender
>> >by
>> >reply email and destroy all copies of the original message.
>> >-----------------------------------------------------------------------------------
>> >_______________________________________________
>> >edk2-devel mailing list
>> >edk2-devel@lists.01.org
>> >https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-11-29  0:38 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-08 19:04 [PATCH v3 0/2] SortLib for UEFI SEC Jeff Brasen
2018-11-08 19:04 ` [PATCH v3 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() Jeff Brasen
2018-11-08 19:04 ` [PATCH v3 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Jeff Brasen
2018-11-09  2:38   ` Zeng, Star
2018-11-08 23:46 ` [PATCH v3 0/2] SortLib for UEFI SEC Carsey, Jaben
2018-11-28 17:17   ` Jeff Brasen
2018-11-28 17:55     ` Jeff Brasen
2018-11-29  0:26       ` Gao, Liming
2018-11-29  0:27         ` Ard Biesheuvel
2018-11-29  0:38           ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox