From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C1BA92118EF65 for ; Tue, 4 Dec 2018 16:04:58 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2018 16:04:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,316,1539673200"; d="scan'208";a="98093386" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 04 Dec 2018 16:04:58 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Dec 2018 16:04:57 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Dec 2018 16:04:57 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.176]) with mapi id 14.03.0415.000; Wed, 5 Dec 2018 08:04:55 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" , Laszlo Ersek Thread-Topic: [edk2] [PATCH v2 0/6] BaseTools: get rid of MAX_UINTN Thread-Index: AQHUiP5ypUjRywBXxUiOPuSvTnUbt6VvR+mw Date: Wed, 5 Dec 2018 00:04:54 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E383BC6@SHSMSX104.ccr.corp.intel.com> References: <20181130224537.18936-1-ard.biesheuvel@linaro.org> In-Reply-To: <20181130224537.18936-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/6] BaseTools: get rid of MAX_UINTN X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 00:04:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao for this serials.=20 On patch 4, I have the same comments to Laszlo.=20 >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Saturday, December 01, 2018 6:46 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Carsey, Jaben >; Laszlo Ersek >Subject: [edk2] [PATCH v2 0/6] BaseTools: get rid of MAX_UINTN > >There should be no reason for the build tools to care about the native >word size of a particular target, so relying on a definition of MAX_UINTN >is definitely wrong, and most likely inaccurate on 32-bit build hosts. > >So refactor the code in CommonLib and DevicePath so we no longer rely >on this definition. > >Changes since v1: >- miss type change in #1 causing a build failure on MSVC >- add acks from Jaben > >Cc: Laszlo Ersek >Cc: Yonghong Zhu >Cc: Liming Gao >Cc: Bob Feng >Cc: Jaben Carsey > >Ard Biesheuvel (6): > BaseTools/CommonLib: avoid using 'native' word size in IP address > handling > BaseTools/CommonLib: use explicit 64-bit type in Strtoi() > BaseTools/DevicePath: use explicit 64-bit number parsing routines > BaseTools/DevicePath: use MAX_UINT16 as default device path max size > BaseTools/CommonLib: get rid of 'native' type string parsing routines > BaseTools/CommonLib: drop definition of MAX_UINTN > > BaseTools/Source/C/Common/CommonLib.h | 25 --- > BaseTools/Source/C/Common/CommonLib.c | 206 ++---------------- > .../Source/C/DevicePath/DevicePathFromText.c | 4 +- > .../Source/C/DevicePath/DevicePathUtilities.c | 4 +- > 4 files changed, 25 insertions(+), 214 deletions(-) > >-- >2.19.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel