From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1599421198CD0 for ; Sun, 9 Dec 2018 17:44:43 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2018 17:44:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,336,1539673200"; d="scan'208";a="100216732" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 09 Dec 2018 17:44:43 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Dec 2018 17:44:42 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Dec 2018 17:44:42 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Mon, 10 Dec 2018 09:44:40 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] ModuleWriteGuide: Add notes to define library instance module type Thread-Index: AQHUkCUicIw8OsntX0uX3NGUPAuelaV3M3pQ Date: Mon, 10 Dec 2018 01:44:40 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E388FB9@SHSMSX104.ccr.corp.intel.com> References: <1543982345-13708-1-git-send-email-liming.gao@intel.com> <1543982345-13708-3-git-send-email-liming.gao@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB401A2D9B@shsmsx102.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB401A2D9B@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] ModuleWriteGuide: Add notes to define library instance module type X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 01:44:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you. I will update it and push the change.=20 >-----Original Message----- >From: Bi, Dandan >Sent: Monday, December 10, 2018 9:10 AM >To: Gao, Liming ; edk2-devel@lists.01.org >Subject: RE: [Patch] ModuleWriteGuide: Add notes to define library instanc= e >module type > >Hi Liming, > >Some minor comments inline. > >Thanks, >Dandan > >> -----Original Message----- >> From: Gao, Liming >> Sent: Wednesday, December 5, 2018 11:59 AM >> To: edk2-devel@lists.01.org >> Cc: Bi, Dandan >> Subject: [Patch] ModuleWriteGuide: Add notes to define library instance >> module type >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=3D834 >> If the library instance supports the cross module types PEIM, UEFI_DIRVE= R, >> DXE_DRIVER. Its module type can be PEIM or UEFI_DRIVER or DXE_DRIVER. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Liming Gao >> Cc: Bi Dandan >> --- >> 3_module_development/31_what_is_an_edk_ii_module.md | 2 ++ >> 3_module_development/32_creating_a_module.md | 5 +++++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/3_module_development/31_what_is_an_edk_ii_module.md >> b/3_module_development/31_what_is_an_edk_ii_module.md >> index ace8d53..9f0fe8d 100644 >> --- a/3_module_development/31_what_is_an_edk_ii_module.md >> +++ b/3_module_development/31_what_is_an_edk_ii_module.md >> @@ -78,6 +78,8 @@ EDK II defines many module types. The module type is >> used to: >> example, a PEIM/DXE_DRIVER type module can have "depex" section >in .efi >> binary image; a UEFI_DRIVER can have .ui or .ver section in .efi bina= ry >image; >> >> +* Indicate EntryPoint() or Constructor() API for different types of mod= ules. >How about "Indicate different prototypes of EntryPoint() or Constructor()= API >for different types of modules"? >> + >> * Indicate the suitable library instance for different types of modules= . A >> library instance will point out what module types are supported in IN= F file. >> >> diff --git a/3_module_development/32_creating_a_module.md >> b/3_module_development/32_creating_a_module.md >> index 65a4ac7..325156f 100644 >> --- a/3_module_development/32_creating_a_module.md >> +++ b/3_module_development/32_creating_a_module.md >> @@ -197,6 +197,11 @@ instance: >> DebugLib >> ``` >> >> +Note: if the library supports the cross module types PEIM, UEFI_DIRVER, >> DXE_DRIVER. >> +Its module type can be PEIM or UEFI_DRIVER or DXE_DRIVER. If it has the >> +library constructor, its module type must be BASE. BASE type library >> +constructor has no the input parameter that can link to the cross drive= r >> types. >How about "BASE type library constructor has no input parameter that can b= e >linked to any type of cross driver"? > >If you agree the updates, please update them before commit, not require V= 2 >patch. >> + >> ### 3.2.3 Adding a Package Dependency >> >> The [Packages] section of the INF file describes all packages dependenc= ies >of >> -- >> 2.13.0.windows.1