From: "Gao, Liming" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Feng, Bob C" <bob.c.feng@intel.com>
Cc: Andrew Fish <afish@apple.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses
Date: Tue, 11 Dec 2018 13:15:20 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E38A1F4@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu8MydrKRU_o_qXmugyTN4NFTsz_uF2nxmyz3HZLcOFx=A@mail.gmail.com>
BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1390 is submit for it. Bob will fix it.
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, December 11, 2018 3:54 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses
>
> On Tue, 11 Dec 2018 at 01:53, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > If PCD is related to one structure in DEC/DSC, it can be refer as structure pointer in C source code. Here is wiki for its usage:
> https://github.com/lgao4/edk2/wiki/StrucutrePcd-Usage
> >
>
> OK so I now have this in my .dec file
>
> [PcdsDynamic]
> gAmdStyxTokenSpaceGuid.PcdEthMacA|{0}|UINT8[6]|0x000d0001
> gAmdStyxTokenSpaceGuid.PcdEthMacB|{0}|UINT8[6]|0x000d0002
>
> and this in my .dsc file
>
> [PcdsDynamicDefault.common]
> gAmdStyxTokenSpaceGuid.PcdEthMacA|{0x2,0xA1,0xA2,0xA3,0xA4,0xA5}
> gAmdStyxTokenSpaceGuid.PcdEthMacB|{0x2,0xB1,0xB2,0xB3,0xB4,0xB5}
>
> and the build errors out immediately with:
>
> Processing meta-data .......
>
> build.py...
> : error F015: /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/PcdValueInit.c:15:20:
> error: ‘gAmdStyxTokenSpaceGuid_PcdEthMacB_DEFAULT_STANDARD_Value’
> undeclared (first use in this function)
> /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/PcdValueInit.c:41:16:
> error: ‘gAmdStyxTokenSpaceGuid_PcdEthMacB_DEFAULT_STANDARD_Value’
> undeclared (first use in this function)
> /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/PcdValueInit.c:74:20:
> error: ‘gAmdStyxTokenSpaceGuid_PcdEthMacA_DEFAULT_STANDARD_Value’
> undeclared (first use in this function)
> /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/PcdValueInit.c:100:16:
> error: ‘gAmdStyxTokenSpaceGuid_PcdEthMacA_DEFAULT_STANDARD_Value’
> undeclared (first use in this function)
next prev parent reply other threads:[~2018-12-11 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 20:10 [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses Ard Biesheuvel
2018-12-10 22:14 ` Leif Lindholm
2018-12-10 22:51 ` Ard Biesheuvel
2018-12-10 23:33 ` Leif Lindholm
2018-12-10 23:38 ` Andrew Fish
2018-12-11 0:53 ` Gao, Liming
2018-12-11 7:54 ` Ard Biesheuvel
2018-12-11 13:15 ` Gao, Liming [this message]
2018-12-11 13:38 ` Feng, Bob C
2018-12-11 13:48 ` Ard Biesheuvel
2018-12-11 13:57 ` Feng, Bob C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E38A1F4@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox