From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C2C9D2119C8B0 for ; Wed, 12 Dec 2018 06:01:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2018 06:01:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,344,1539673200"; d="scan'208";a="117754115" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 12 Dec 2018 06:01:11 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 06:01:11 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 06:01:11 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by shsmsx102.ccr.corp.intel.com ([169.254.2.182]) with mapi id 14.03.0415.000; Wed, 12 Dec 2018 22:01:09 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Feng, Bob C" , Leif Lindholm , "Laszlo Ersek" Thread-Topic: [PATCH 0/3] fixes for CLANG35 on ARM Thread-Index: AQHUkgYeYLa+1dZJ+0GkpcLyLtzhFqV7ITvw Date: Wed, 12 Dec 2018 14:01:07 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E38B9CB@SHSMSX104.ccr.corp.intel.com> References: <20181212103308.8099-1-ard.biesheuvel@linaro.org> In-Reply-To: <20181212103308.8099-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTdhYTFhZmQtM2Y5NS00MDMxLTg3ZGYtMDkzYzNhMzFiOWU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM2gzYUtvTk82UHZSeHowY3JKTUdIa0Z1bHpSblVpaThwNnB3cE5FZjBCeE80NTBZRmRzU21MRzllV2UrZWxodCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] fixes for CLANG35 on ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 14:01:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard: I have no comments on this patch. So, CLANG38 has no issue. If so, could = you recommend use CLANG38?=20 Thanks Liming > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Wednesday, December 12, 2018 6:33 PM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming > ; Feng, Bob C ; Leif Lindholm= ; Laszlo Ersek > > Subject: [PATCH 0/3] fixes for CLANG35 on ARM >=20 > Building with Clang 3.5 for ARM may result in build breakage, due to the > fact that it may emit non-adjacent movw/movt instructions pairs which > cannot be relocated in PE/COFF. We pass -mno-movt in some places to > work around a related issue in the relocatable PrePi in ArmVirtPkg, but > we need to disable movw/movt entirely to really address this issue. >=20 > So first, fix some breakage that results from building with -mlong-calls > in the optimized BaseMemoryLib code (#1) >=20 > Patch #2 switches to -mkernel, which disables movw/movt generation (and > enabled -mlong-calls as a side effect) >=20 > Patch #3 removes the now redundant, and incompatible command line > overrides for the relocatable PrePi. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Bob Feng > Cc: Leif Lindholm > Cc: Laszlo Ersek >=20 > Ard Biesheuvel (3): > MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations > BaseTools/tools_def ARM CLANG35: work around -mno-movt option name > change > ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option >=20 > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > ArmVirtPkg/ArmVirtXen.dsc | 5 ----- > BaseTools/Conf/tools_def.template | 2 +- > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++ > 7 files changed, 9 insertions(+), 11 deletions(-) >=20 > -- > 2.19.2