From: "Gao, Liming" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 0/3] fixes for CLANG35 on ARM
Date: Wed, 12 Dec 2018 14:19:07 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E38BA28@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu8Diew+xgnd0skfG4OOtdKodX=1xOcdDorg6xVYeqpG2Q@mail.gmail.com>
Make sense. So, CLANG35 tool chain can also be used by CLANG 3.5 and above version compiler, like GCC49?
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
> Sent: Wednesday, December 12, 2018 10:03 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org; Laszlo Ersek <lersek@redhat.com>
> Subject: Re: [edk2] [PATCH 0/3] fixes for CLANG35 on ARM
>
> On Wed, 12 Dec 2018 at 15:01, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > Ard:
> > I have no comments on this patch. So, CLANG38 has no issue. If so, could you recommend use CLANG38?
> >
>
> Yes, the latest is always preferred. However, since CLANG38 enables
> LTO, you need the LLVMgold plugin, which is not shipped for all
> versions of Clang by the distros. So it is good to keep CLANG35 as a
> fallback.
>
> > > -----Original Message-----
> > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > > Sent: Wednesday, December 12, 2018 6:33 PM
> > > To: edk2-devel@lists.01.org
> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Laszlo Ersek
> > > <lersek@redhat.com>
> > > Subject: [PATCH 0/3] fixes for CLANG35 on ARM
> > >
> > > Building with Clang 3.5 for ARM may result in build breakage, due to the
> > > fact that it may emit non-adjacent movw/movt instructions pairs which
> > > cannot be relocated in PE/COFF. We pass -mno-movt in some places to
> > > work around a related issue in the relocatable PrePi in ArmVirtPkg, but
> > > we need to disable movw/movt entirely to really address this issue.
> > >
> > > So first, fix some breakage that results from building with -mlong-calls
> > > in the optimized BaseMemoryLib code (#1)
> > >
> > > Patch #2 switches to -mkernel, which disables movw/movt generation (and
> > > enabled -mlong-calls as a side effect)
> > >
> > > Patch #3 removes the now redundant, and incompatible command line
> > > overrides for the relocatable PrePi.
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > >
> > > Ard Biesheuvel (3):
> > > MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations
> > > BaseTools/tools_def ARM CLANG35: work around -mno-movt option name
> > > change
> > > ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option
> > >
> > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 -----
> > > ArmVirtPkg/ArmVirtXen.dsc | 5 -----
> > > BaseTools/Conf/tools_def.template | 2 +-
> > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 +
> > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 +
> > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 +
> > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++
> > > 7 files changed, 9 insertions(+), 11 deletions(-)
> > >
> > > --
> > > 2.19.2
> >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-12-12 14:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 10:33 [PATCH 0/3] fixes for CLANG35 on ARM Ard Biesheuvel
2018-12-12 10:33 ` [PATCH 1/3] MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations Ard Biesheuvel
2018-12-12 11:48 ` Laszlo Ersek
2018-12-12 10:33 ` [PATCH 2/3] BaseTools/tools_def ARM CLANG35: work around -mno-movt option name change Ard Biesheuvel
2018-12-12 11:49 ` Laszlo Ersek
2018-12-12 11:51 ` Ard Biesheuvel
2018-12-12 12:04 ` Laszlo Ersek
2018-12-12 12:30 ` Ard Biesheuvel
2018-12-12 12:34 ` Leif Lindholm
2018-12-12 10:33 ` [PATCH 3/3] ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option Ard Biesheuvel
2018-12-12 11:51 ` Laszlo Ersek
2018-12-12 12:37 ` [PATCH 0/3] fixes for CLANG35 on ARM Leif Lindholm
2018-12-12 14:01 ` Gao, Liming
2018-12-12 14:02 ` Ard Biesheuvel
2018-12-12 14:19 ` Gao, Liming [this message]
2018-12-12 14:19 ` Ard Biesheuvel
2018-12-13 10:49 ` Ard Biesheuvel
2018-12-13 11:42 ` Gao, Liming
2018-12-13 11:49 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E38BA28@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox