From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 375692119C89D for ; Wed, 12 Dec 2018 06:19:11 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2018 06:19:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,344,1539673200"; d="scan'208";a="283003070" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 12 Dec 2018 06:19:10 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 06:19:10 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 06:19:09 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Wed, 12 Dec 2018 22:19:08 +0800 From: "Gao, Liming" To: Ard Biesheuvel CC: "Kinney, Michael D" , "edk2-devel@lists.01.org" , Laszlo Ersek Thread-Topic: [edk2] [PATCH 0/3] fixes for CLANG35 on ARM Thread-Index: AQHUkgYeYLa+1dZJ+0GkpcLyLtzhFqV7ITvw//97WgCAAIprUA== Date: Wed, 12 Dec 2018 14:19:07 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E38BA28@SHSMSX104.ccr.corp.intel.com> References: <20181212103308.8099-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E38B9CB@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTExMjhmNWYtZDM5NC00ZWY1LTg3NjgtNjI4MjJhMGJlYjMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM2c4VlRHUHg3UlQzMTk1UGF5d2RNa3lOYmZ5d05HXC9qQkJwNVJUSWtMSHdkUWVYTFZMUG5qWE5RanY1SXNjenAifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] fixes for CLANG35 on ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 14:19:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Make sense. So, CLANG35 tool chain can also be used by CLANG 3.5 and above = version compiler, like GCC49? > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ar= d Biesheuvel > Sent: Wednesday, December 12, 2018 10:03 PM > To: Gao, Liming > Cc: Kinney, Michael D ; edk2-devel@lists.01.o= rg; Laszlo Ersek > Subject: Re: [edk2] [PATCH 0/3] fixes for CLANG35 on ARM >=20 > On Wed, 12 Dec 2018 at 15:01, Gao, Liming wrote: > > > > Ard: > > I have no comments on this patch. So, CLANG38 has no issue. If so, co= uld you recommend use CLANG38? > > >=20 > Yes, the latest is always preferred. However, since CLANG38 enables > LTO, you need the LLVMgold plugin, which is not shipped for all > versions of Clang by the distros. So it is good to keep CLANG35 as a > fallback. >=20 > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > Sent: Wednesday, December 12, 2018 6:33 PM > > > To: edk2-devel@lists.01.org > > > Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming > > > ; Feng, Bob C ; Leif Lind= holm ; Laszlo Ersek > > > > > > Subject: [PATCH 0/3] fixes for CLANG35 on ARM > > > > > > Building with Clang 3.5 for ARM may result in build breakage, due to = the > > > fact that it may emit non-adjacent movw/movt instructions pairs which > > > cannot be relocated in PE/COFF. We pass -mno-movt in some places to > > > work around a related issue in the relocatable PrePi in ArmVirtPkg, b= ut > > > we need to disable movw/movt entirely to really address this issue. > > > > > > So first, fix some breakage that results from building with -mlong-ca= lls > > > in the optimized BaseMemoryLib code (#1) > > > > > > Patch #2 switches to -mkernel, which disables movw/movt generation (a= nd > > > enabled -mlong-calls as a side effect) > > > > > > Patch #3 removes the now redundant, and incompatible command line > > > overrides for the relocatable PrePi. > > > > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Bob Feng > > > Cc: Leif Lindholm > > > Cc: Laszlo Ersek > > > > > > Ard Biesheuvel (3): > > > MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations > > > BaseTools/tools_def ARM CLANG35: work around -mno-movt option name > > > change > > > ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option > > > > > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > > > ArmVirtPkg/ArmVirtXen.dsc | 5 ----- > > > BaseTools/Conf/tools_def.template | 2 +- > > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 + > > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 + > > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 + > > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++ > > > 7 files changed, 9 insertions(+), 11 deletions(-) > > > > > > -- > > > 2.19.2 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel