Re: [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove an unused function

["Gao, Liming" <liming.gao@intel.com>]

Shenglei:
  Please submit one BZ for this change. 

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Shenglei Zhang
>Sent: Thursday, December 13, 2018 1:33 PM
>To: edk2-devel@lists.01.org
>Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [edk2] [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove an
>unused function
>
>CharToUpper is an unused internal function, so it will be removed.
>
>Cc: Jaben Carsey <jaben.carsey@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../UefiShellDebug1CommandsLib.c              | 28 -------------------
> 1 file changed, 28 deletions(-)
>
>diff --git
>a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command
>sLib.c
>b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
>dsLib.c
>index bd4dfa98f7..480441b0f9 100644
>---
>a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command
>sLib.c
>+++
>b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
>dsLib.c
>@@ -113,34 +113,6 @@ UefiShellDebug1CommandsLibDestructor (
>   return (EFI_SUCCESS);
> }
>
>-/**
>-  Convert a Unicode character to upper case only if
>-  it maps to a valid small-case ASCII character.
>-
>-  This internal function only deal with Unicode character
>-  which maps to a valid small-case ASCII character, i.e.
>-  L'a' to L'z'. For other Unicode character, the input character
>-  is returned directly.
>-
>-  @param  Char  The character to convert.
>-
>-  @retval LowerCharacter   If the Char is with range L'a' to L'z'.
>-  @retval Unchanged        Otherwise.
>-
>-
>-  //Stolen from MdePkg Baselib
>-**/
>-CHAR16
>-CharToUpper (
>-  IN      CHAR16                    Char
>-  )
>-{
>-  if (Char >= L'a' && Char <= L'z') {
>-    return (CHAR16) (Char - (L'a' - L'A'));
>-  }
>-
>-  return Char;
>-}
>
> /**
>   Function returns a system configuration table that is stored in the
>--
>2.18.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel