From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 717BE2119BBCE for ; Wed, 12 Dec 2018 22:17:04 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2018 22:17:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,347,1539673200"; d="scan'208";a="107081518" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 12 Dec 2018 22:17:03 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 22:17:03 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Thu, 13 Dec 2018 14:17:01 +0800 From: "Gao, Liming" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" , "Ni, Ruiyu" Thread-Topic: [edk2] [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove an unused function Thread-Index: AQHUkqV2pmrsR3g58E6gxu68DhXzlaV8MYbg Date: Thu, 13 Dec 2018 06:17:00 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E38BFA5@SHSMSX104.ccr.corp.intel.com> References: <20181213053328.24336-1-shenglei.zhang@intel.com> In-Reply-To: <20181213053328.24336-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove an unused function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 06:17:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Shenglei: Please submit one BZ for this change.=20 >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Shenglei Zhang >Sent: Thursday, December 13, 2018 1:33 PM >To: edk2-devel@lists.01.org >Cc: Carsey, Jaben ; Ni, Ruiyu >Subject: [edk2] [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove an >unused function > >CharToUpper is an unused internal function, so it will be removed. > >Cc: Jaben Carsey >Cc: Ruiyu Ni >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Shenglei Zhang >--- > .../UefiShellDebug1CommandsLib.c | 28 ------------------- > 1 file changed, 28 deletions(-) > >diff --git >a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command >sLib.c >b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman >dsLib.c >index bd4dfa98f7..480441b0f9 100644 >--- >a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command >sLib.c >+++ >b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman >dsLib.c >@@ -113,34 +113,6 @@ UefiShellDebug1CommandsLibDestructor ( > return (EFI_SUCCESS); > } > >-/** >- Convert a Unicode character to upper case only if >- it maps to a valid small-case ASCII character. >- >- This internal function only deal with Unicode character >- which maps to a valid small-case ASCII character, i.e. >- L'a' to L'z'. For other Unicode character, the input character >- is returned directly. >- >- @param Char The character to convert. >- >- @retval LowerCharacter If the Char is with range L'a' to L'z'. >- @retval Unchanged Otherwise. >- >- >- //Stolen from MdePkg Baselib >-**/ >-CHAR16 >-CharToUpper ( >- IN CHAR16 Char >- ) >-{ >- if (Char >=3D L'a' && Char <=3D L'z') { >- return (CHAR16) (Char - (L'a' - L'A')); >- } >- >- return Char; >-} > > /** > Function returns a system configuration table that is stored in the >-- >2.18.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel