public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fixed build report issue.
Date: Wed, 2 Jan 2019 01:39:47 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E39FB91@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20181229084446.23308-1-bob.c.feng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com

>-----Original Message-----
>From: Feng, Bob C
>Sent: Saturday, December 29, 2018 4:45 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Fixed build report issue.
>
>From: "Feng, Bob C" <bob.c.feng@intel.com>
>
>This patch is going to fix the regression issue
>by 72a1d77694d51914c0dd6aa97dbfa58634b0a4a5
>
>After enable PCD array, the Pcd.OverrideStruct has a new
>key, array index, but the build report is not changed correspondingly.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index d379866618..3f3c1a12f1 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -1422,13 +1422,14 @@ class PcdReport(object):
>                     self.PrintPcdDefault(File, Pcd, IsStructure, DscMatch,
>DscDefaultValue, InfMatch, InfDefaultValue, DecMatch, DecDefaultValue)
>
>     def OverrideFieldValue(self, Pcd, OverrideStruct):
>         OverrideFieldStruct = collections.OrderedDict()
>         if OverrideStruct:
>-            for Key, Values in OverrideStruct.items():
>-                if Values[1] and Values[1].endswith('.dsc'):
>-                    OverrideFieldStruct[Key] = Values
>+            for _, Values in OverrideStruct.items():
>+                for Key,value in Values.items():
>+                    if value[1] and value[1].endswith('.dsc'):
>+                        OverrideFieldStruct[Key] = value
>         if Pcd.PcdFieldValueFromFdf:
>             for Key, Values in Pcd.PcdFieldValueFromFdf.items():
>                 if Key in OverrideFieldStruct and Values[0] ==
>OverrideFieldStruct[Key][0]:
>                     continue
>                 OverrideFieldStruct[Key] = Values
>--
>2.19.1.windows.1



      reply	other threads:[~2019-01-02  1:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-29  8:44 [Patch] BaseTools: Fixed build report issue BobCF
2019-01-02  1:39 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E39FB91@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox