From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 381D42119BBD9 for ; Thu, 10 Jan 2019 07:22:39 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 07:22:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,461,1539673200"; d="scan'208";a="137115208" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2019 07:22:38 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 10 Jan 2019 07:22:38 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.44]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.196]) with mapi id 14.03.0415.000; Thu, 10 Jan 2019 23:22:36 +0800 From: "Gao, Liming" To: Ashish Singhal , "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation Thread-Index: AQHUqF4gh1LNMbj43UaDqSkiiXTyqqWnJ5KAgAAGdwCAAXFUcA== Date: Thu, 10 Jan 2019 15:22:36 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AF073@SHSMSX152.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDdlMGRiZTQtNzRjNS00ZjljLTg0OGMtNjlmNmM5ZTYzMDRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWUZVZHZxRTdzQm9qbWRrMFEzbUhsUWpIbFpkcU5tUVlkS252TDBVTFwvRndlK29CNWVCaVd1MmpSOGlIbFwvWkRlIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 15:22:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ashish: The MdePkg change is good to me. Reviewed-by: Liming Gao Please help submit another BZ to update UefiDriver to uninstall protocol = when failure with new APIs.=20 =20 If Siyuan/Jiaxin has no other comments, I will help push this patch set.= =20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of As= hish Singhal > Sent: Thursday, January 10, 2019 9:19 AM > To: Kinney, Michael D ; edk2-devel@lists.01.o= rg > Cc: Fu, Siyuan ; Wu, Jiaxin ; G= ao, Liming > Subject: Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol= uninstallation >=20 > Thanks Mike. Hope to see the patches merged soon. Please let me know if y= ou want me to file the BZ. >=20 > Hi Liming, >=20 > Please let me know if you need me to take care of anything in the patch b= efore you push it. >=20 > Hi Siyuan/Jiaxin, >=20 > I think you reviewed the changes in PATCH v2 which is same as in PATCH v4= . Please let me know if you have any issues with this going in. >=20 > Thanks > Ashish >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, January 9, 2019 5:56 PM > To: Ashish Singhal ; edk2-devel@lists.01.org; Ki= nney, Michael D > Cc: Gao, Liming ; Fu, Siyuan ;= Wu, Jiaxin > Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol uninst= allation >=20 > Hi Ashish, >=20 > This V4 version of the patch produces the expected size results for platf= orm and driver builds. >=20 > There are some very minor issues with some extra carriage returns, but th= ose can be handled by Liming when the patch series is > committed. >=20 > I may be good to have an additional BZ to use these new APIs from all UEF= I Driver Model drivers that have failure paths in their entry > point or support the unload feature. > Those updates can be done later. >=20 > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > > Sent: Wednesday, January 9, 2019 12:59 PM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D ; Gao, Liming > > ; Fu, Siyuan ; Wu, Jiaxin > > ; Ashish Singhal > > Subject: [PATCH v4 0/2] Provide UEFILib functions for protocol > > uninstallation > > > > An issue was seen in IScsiDxe in NetworkPkg where driver cleanup after > > initialization failure was not done right. Bug 1428 was filed in this > > regard. > > As per discussions with Mike, it was also discussed that having > > UEFILib provide protocol uninstallation abstraction would help to > > avoid these issues in the future. Bug 1429 was found to track this. > > These 2 patches > > take care of this. > > > > > > Ashish Singhal (2): > > MdePkg/UefiLib: Abstract driver model protocol uninstallation > > NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. > > > > MdePkg/Include/Library/UefiLib.h | 103 ++++ > > MdePkg/Library/UefiLib/UefiDriverModel.c | 972 > > ++++++++++++++++++++++++++++++- > > NetworkPkg/IScsiDxe/IScsiDriver.c | 31 +- > > 3 files changed, 1085 insertions(+), 21 deletions(-) > > > > -- > > 2.7.4 >=20 > -------------------------------------------------------------------------= ---------- > This email message is for the sole use of the intended recipient(s) and m= ay contain > confidential information. Any unauthorized review, use, disclosure or di= stribution > is prohibited. If you are not the intended recipient, please contact the= sender by > reply email and destroy all copies of the original message. > -------------------------------------------------------------------------= ---------- > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel