public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools
Date: Mon, 14 Jan 2019 00:04:41 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B0DE3@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <20190109083455.60404-1-bob.c.feng@intel.com>

Bob:
  This change is not related to ECP. Please keep this definition. 

>-----Original Message-----
>From: Feng, Bob C
>Sent: Wednesday, January 09, 2019 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
>Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C
>tools
>
>From: "Feng, Bob C" <bob.c.feng@intel.com>
>
>https://bugzilla.tianocore.org/show_bug.cgi?id=1350
>Remove ECP support from BaseTools C code.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Jaben Carsey <jaben.carsey@intel.com>
>---
> BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h
>b/BaseTools/Source/C/Include/IndustryStandard/pci22.h
>index d7c5f0c858..873ce69094 100644
>--- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h
>+++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h
>@@ -178,11 +178,10 @@ typedef struct {
> #define PCI_IF_16850                  0x05
> #define PCI_IF_16950                  0x06
> #define PCI_SUBCLASS_PARALLEL         0x01
> #define PCI_IF_PARALLEL_PORT          0x00
> #define PCI_IF_BI_DIR_PARALLEL_PORT   0x01
>-#define PCI_IF_ECP_PARALLEL_PORT      0x02
> #define PCI_IF_1284_CONTROLLER        0x03
> #define PCI_IF_1284_DEVICE            0xFE
> #define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02
> #define PCI_SUBCLASS_MODEM            0x03
> #define PCI_IF_GENERIC_MODEM          0x00
>--
>2.19.1.windows.1



      parent reply	other threads:[~2019-01-14  0:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  8:34 [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools BobCF
2019-01-09 18:52 ` Carsey, Jaben
2019-01-14  0:04 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3B0DE3@SHSMSX152.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox