From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 011AD211B7378 for ; Sun, 13 Jan 2019 16:04:45 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2019 16:04:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,475,1539673200"; d="scan'208";a="127416574" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 13 Jan 2019 16:04:44 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 13 Jan 2019 16:04:44 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 13 Jan 2019 16:04:44 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.44]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.160]) with mapi id 14.03.0415.000; Mon, 14 Jan 2019 08:04:41 +0800 From: "Gao, Liming" To: "Feng, Bob C" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools Thread-Index: AQHUp/Y87ia2nRZ4aES1fqhoDHS9a6Wt6XiQ Date: Mon, 14 Jan 2019 00:04:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B0DE3@SHSMSX152.ccr.corp.intel.com> References: <20190109083455.60404-1-bob.c.feng@intel.com> In-Reply-To: <20190109083455.60404-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C tools X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 00:04:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob: This change is not related to ECP. Please keep this definition.=20 >-----Original Message----- >From: Feng, Bob C >Sent: Wednesday, January 09, 2019 4:35 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >; Carsey, Jaben >Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C >tools > >From: "Feng, Bob C" > >https://bugzilla.tianocore.org/show_bug.cgi?id=3D1350 >Remove ECP support from BaseTools C code. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Bob Feng >Cc: Liming Gao >Cc: Jaben Carsey >--- > BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/BaseTools/Source/C/Include/IndustryStandard/pci22.h >b/BaseTools/Source/C/Include/IndustryStandard/pci22.h >index d7c5f0c858..873ce69094 100644 >--- a/BaseTools/Source/C/Include/IndustryStandard/pci22.h >+++ b/BaseTools/Source/C/Include/IndustryStandard/pci22.h >@@ -178,11 +178,10 @@ typedef struct { > #define PCI_IF_16850 0x05 > #define PCI_IF_16950 0x06 > #define PCI_SUBCLASS_PARALLEL 0x01 > #define PCI_IF_PARALLEL_PORT 0x00 > #define PCI_IF_BI_DIR_PARALLEL_PORT 0x01 >-#define PCI_IF_ECP_PARALLEL_PORT 0x02 > #define PCI_IF_1284_CONTROLLER 0x03 > #define PCI_IF_1284_DEVICE 0xFE > #define PCI_SUBCLASS_MULTIPORT_SERIAL 0x02 > #define PCI_SUBCLASS_MODEM 0x03 > #define PCI_IF_GENERIC_MODEM 0x00 >-- >2.19.1.windows.1