Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations

["Gao, Liming" <liming.gao@intel.com>]

Ard:
  Could you consider the suggestion from https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html?

Thanks
Liming
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, January 14, 2019 7:42 PM
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
> 
> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote:
> > GCC for 32-bit ARM chokes on .aslc files when running with LTO
> > enabled. Since LTO has no benefit whatsoever here, just disable
> > it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Looks sensible.
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> > ---
> >  BaseTools/Conf/tools_def.template | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> > index f7eb87af14c2..e68cfd9a4997 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS     = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> >  *_GCC5_ARM_RC_PATH               = ENV(GCC5_ARM_PREFIX)objcopy
> >
> >  *_GCC5_ARM_ARCHCC_FLAGS          = -mthumb
> > -*_GCC5_ARM_ASLCC_FLAGS           = DEF(GCC_ASLCC_FLAGS)
> > +*_GCC5_ARM_ASLCC_FLAGS           = DEF(GCC_ASLCC_FLAGS) -fno-lto
> >  *_GCC5_ARM_ASLDLINK_FLAGS        = DEF(GCC5_ARM_ASLDLINK_FLAGS)
> >  *_GCC5_ARM_ASM_FLAGS             = DEF(GCC5_ARM_ASM_FLAGS)
> >  *_GCC5_ARM_DLINK2_FLAGS          = DEF(GCC5_ARM_DLINK2_FLAGS)
> > --
> > 2.20.1
> >