From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 653632119FF5E for ; Mon, 14 Jan 2019 05:18:25 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 05:18:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,477,1539673200"; d="scan'208";a="106456886" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 14 Jan 2019 05:18:24 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 05:18:24 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 05:18:23 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.44]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.196]) with mapi id 14.03.0415.000; Mon, 14 Jan 2019 21:18:22 +0800 From: "Gao, Liming" To: Leif Lindholm , Ard Biesheuvel CC: "edk2-devel@lists.01.org" , "Feng, Bob C" Thread-Topic: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations Thread-Index: AQHUq/4pBmFmNV56EkeuTzeOIKe0FaWuvx9A Date: Mon, 14 Jan 2019 13:18:21 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B156E@SHSMSX152.ccr.corp.intel.com> References: <20190107065541.1854-1-ard.biesheuvel@linaro.org> <20190114114138.ttqlr5mfzh465pic@bivouac.eciton.net> In-Reply-To: <20190114114138.ttqlr5mfzh465pic@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDRhZDUyZjUtODEwZS00YzlmLThlNmEtNDc1MDM2MTc2NDExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieEFvM21rbWFmWkVxa3A3XC9BVGp4b0FQXC85RVJtTTJCXC9CUjJmdVhlcWw0d3N4d3J5VjFmQlNvVzB2aVNXMDdwTyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 13:18:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard: Could you consider the suggestion from https://lists.01.org/pipermail/edk= 2-devel/2019-January/034698.html? Thanks Liming > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Monday, January 14, 2019 7:42 PM > To: Ard Biesheuvel > Cc: edk2-devel@lists.01.org; Gao, Liming ; Feng, Bo= b C > Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC i= nvocations >=20 > On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote: > > GCC for 32-bit ARM chokes on .aslc files when running with LTO > > enabled. Since LTO has no benefit whatsoever here, just disable > > it. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel >=20 > Looks sensible. > Reviewed-by: Leif Lindholm >=20 > > --- > > BaseTools/Conf/tools_def.template | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_d= ef.template > > index f7eb87af14c2..e68cfd9a4997 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS =3D DEF(GCC5_X64= _DLINK_FLAGS) -flto -Os > > *_GCC5_ARM_RC_PATH =3D ENV(GCC5_ARM_PREFIX)objcopy > > > > *_GCC5_ARM_ARCHCC_FLAGS =3D -mthumb > > -*_GCC5_ARM_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) > > +*_GCC5_ARM_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) -fno-lto > > *_GCC5_ARM_ASLDLINK_FLAGS =3D DEF(GCC5_ARM_ASLDLINK_FLAGS) > > *_GCC5_ARM_ASM_FLAGS =3D DEF(GCC5_ARM_ASM_FLAGS) > > *_GCC5_ARM_DLINK2_FLAGS =3D DEF(GCC5_ARM_DLINK2_FLAGS) > > -- > > 2.20.1 > >