public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
Date: Mon, 14 Jan 2019 13:38:01 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B1638@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <f7622a26-22d8-10d0-5870-d03bacf444da@redhat.com>

I see IA32 and X64 arch both have this option. I have no idea on AArch64. 

> -----Original Message-----
> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
> Sent: Monday, January 14, 2019 9:36 PM
> To: Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
> 
> On 1/14/19 2:18 PM, Gao, Liming wrote:
> > Ard:
> >   Could you consider the suggestion from https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html?
> 
> There might be a special case for Aarch64, but I'm not seeing it.
> 
> >
> > Thanks
> > Liming
> >> -----Original Message-----
> >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> >> Sent: Monday, January 14, 2019 7:42 PM
> >> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> >> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
> >>
> >> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote:
> >>> GCC for 32-bit ARM chokes on .aslc files when running with LTO
> >>> enabled. Since LTO has no benefit whatsoever here, just disable
> >>> it.
> >>>
> >>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >>
> >> Looks sensible.
> >> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> >>
> >>> ---
> >>>  BaseTools/Conf/tools_def.template | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> >>> index f7eb87af14c2..e68cfd9a4997 100755
> >>> --- a/BaseTools/Conf/tools_def.template
> >>> +++ b/BaseTools/Conf/tools_def.template
> >>> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS     = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> >>>  *_GCC5_ARM_RC_PATH               = ENV(GCC5_ARM_PREFIX)objcopy
> >>>
> >>>  *_GCC5_ARM_ARCHCC_FLAGS          = -mthumb
> >>> -*_GCC5_ARM_ASLCC_FLAGS           = DEF(GCC_ASLCC_FLAGS)
> >>> +*_GCC5_ARM_ASLCC_FLAGS           = DEF(GCC_ASLCC_FLAGS) -fno-lto
> >>>  *_GCC5_ARM_ASLDLINK_FLAGS        = DEF(GCC5_ARM_ASLDLINK_FLAGS)
> >>>  *_GCC5_ARM_ASM_FLAGS             = DEF(GCC5_ARM_ASM_FLAGS)
> >>>  *_GCC5_ARM_DLINK2_FLAGS          = DEF(GCC5_ARM_DLINK2_FLAGS)
> >>> --
> >>> 2.20.1
> >>>
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> >

  reply	other threads:[~2019-01-14 13:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07  6:55 [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations Ard Biesheuvel
2019-01-07 10:08 ` Philippe Mathieu-Daudé
2019-01-14 11:41 ` Leif Lindholm
2019-01-14 13:18   ` Gao, Liming
2019-01-14 13:36     ` Philippe Mathieu-Daudé
2019-01-14 13:38       ` Gao, Liming [this message]
2019-01-14 13:46         ` Ard Biesheuvel
2019-01-14 13:57           ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3B1638@SHSMSX152.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox