public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix build report issue.
Date: Thu, 17 Jan 2019 15:37:50 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B3FBB@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <20190116152958.5176-1-bob.c.feng@intel.com>

The patch is good. Reviewed-by: Liming Gao <liming.gao@intel.com>

Please add BZ number URL when push it. 

Thanks
Liming
> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, January 16, 2019 11:30 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Fix build report issue.
> 
> The Pcd Array feature changes the Pcd Default value
> data structure which is used by build report. This
> patch is going to update build report to adapt that change.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/Python/build/BuildReport.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
> index 654a69e05c..ae37a6ce0e 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -1243,13 +1243,15 @@ class PcdReport(object):
>                          Value = '{} ({:d})'.format(Value, int(Value, 0))
>                      else:
>                          Value = "0x{:X} ({})".format(int(Value, 0), Value)
>                  FileWrite(File, '    %*s = %s' % (self.MaxLen + 19, 'DEC DEFAULT', Value))
>              if IsStructure:
> -                self.PrintStructureInfo(File, Pcd.DefaultValues)
> +                for filedvalues in Pcd.DefaultValues.values():
> +                    self.PrintStructureInfo(File, filedvalues)
>          if DecMatch and IsStructure:
> -            self.PrintStructureInfo(File, Pcd.DefaultValues)
> +            for filedvalues in Pcd.DefaultValues.values():
> +                self.PrintStructureInfo(File, filedvalues)
> 
>      def PrintPcdValue(self, File, Pcd, PcdTokenCName, TypeName, IsStructure, DscMatch, DscDefaultValue, InfMatch, InfDefaultValue,
> DecMatch, DecDefaultValue, Flag = '  '):
>          if not Pcd.SkuInfoList:
>              Value = Pcd.DefaultValue
>              IsByteArray, ArrayList = ByteArrayForamt(Value)
> --
> 2.19.1.windows.1



      reply	other threads:[~2019-01-17 15:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 15:29 [Patch] BaseTools: Fix build report issue Feng, Bob C
2019-01-17 15:37 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3B3FBB@SHSMSX152.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox