From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9A6B8211B7361 for ; Thu, 17 Jan 2019 07:37:54 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 07:37:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,489,1539673200"; d="scan'208";a="115445711" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 17 Jan 2019 07:37:54 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 07:37:53 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 07:37:53 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.44]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.85]) with mapi id 14.03.0415.000; Thu, 17 Jan 2019 23:37:51 +0800 From: "Gao, Liming" To: "Feng, Bob C" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Fix build report issue. Thread-Index: AQHUrbBauIKkJcQdN020Hba+pkQg4KWzmZWA Date: Thu, 17 Jan 2019 15:37:50 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B3FBB@SHSMSX152.ccr.corp.intel.com> References: <20190116152958.5176-1-bob.c.feng@intel.com> In-Reply-To: <20190116152958.5176-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjkxNzBmYjMtYmQ5Ni00YTE0LWE4ZTAtM2E0NWEwOTAxOWQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ3RDVUZjaE95Q1VubDJPUFI2Um5DdjRGNnp1RmxMajljSVJuVm1idURVeDNKYVcxTWxNaUw0T1wvOUtwNlpFQ3IifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix build report issue. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 15:37:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patch is good. Reviewed-by: Liming Gao Please add BZ number URL when push it.=20 Thanks Liming > -----Original Message----- > From: Feng, Bob C > Sent: Wednesday, January 16, 2019 11:30 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Fix build report issue. >=20 > The Pcd Array feature changes the Pcd Default value > data structure which is used by build report. This > patch is going to update build report to adapt that change. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/build/BuildReport.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Sou= rce/Python/build/BuildReport.py > index 654a69e05c..ae37a6ce0e 100644 > --- a/BaseTools/Source/Python/build/BuildReport.py > +++ b/BaseTools/Source/Python/build/BuildReport.py > @@ -1243,13 +1243,15 @@ class PcdReport(object): > Value =3D '{} ({:d})'.format(Value, int(Value, 0= )) > else: > Value =3D "0x{:X} ({})".format(int(Value, 0), Va= lue) > FileWrite(File, ' %*s =3D %s' % (self.MaxLen + 19, 'D= EC DEFAULT', Value)) > if IsStructure: > - self.PrintStructureInfo(File, Pcd.DefaultValues) > + for filedvalues in Pcd.DefaultValues.values(): > + self.PrintStructureInfo(File, filedvalues) > if DecMatch and IsStructure: > - self.PrintStructureInfo(File, Pcd.DefaultValues) > + for filedvalues in Pcd.DefaultValues.values(): > + self.PrintStructureInfo(File, filedvalues) >=20 > def PrintPcdValue(self, File, Pcd, PcdTokenCName, TypeName, IsStruct= ure, DscMatch, DscDefaultValue, InfMatch, InfDefaultValue, > DecMatch, DecDefaultValue, Flag =3D ' '): > if not Pcd.SkuInfoList: > Value =3D Pcd.DefaultValue > IsByteArray, ArrayList =3D ByteArrayForamt(Value) > -- > 2.19.1.windows.1