public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: parallelism in the module-level, generated GNUmakefile's
Date: Thu, 24 Jan 2019 09:57:12 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3C14D1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <43f3143e-80cb-477a-5299-f48af4927997@redhat.com>

Yes. BaseTools should make sure the complete dependency in the generated Makefile. If you find any missing, please submit BZs. 

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, January 24, 2019 6:07 AM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: Re: [edk2] parallelism in the module-level, generated GNUmakefile's
> 
> On 01/23/19 17:36, Gao, Liming wrote:
> > Laszlo: By design, BaseTools generates GNUMakefile with the complete
> > dependency. So, the generated GNUMakefile should support parallelism
> > run. But, I don't verify this functionality. Have you found any
> > limitation to forbid parallelism run in module GNUMakefile?
> 
> No, I haven't, and that is what surprised me :) I *expected* problems,
> but didn't find any.
> 
> Given that BaseTools / "build" does not offer any way at all to build a
> single generated  GNUMakefile with "make -j", such parallel builds of
> said GNUMakefiles have never been tested.
> 
> Therefore, I expected them to break, under "make -j".
> 
> When they didn't, I was surprised. :)
> 
> The question is if we can *rely* on BaseTools to generate the
> GNUMakefiles with complete dependencies.
> 
> In other words, if we now start building them with "make -j" (via the
> outer make), and run into an error due to missing dependencies, can we
> report a TianoCore BZ about that? Will it be in scope? Is "complete
> dependencies" an explicit goal?
> 
> If the answer is "yes", I will happily take that answer.
> 
> If the answer is "no", then BaseTools should use .NOTPARALLEL in the
> GNUMakefiles (or else "build" should invoke the inner "make" with an
> explicit "-j1" flag -- as I've learned today).
> 
> Thank you!
> Laszlo


  reply	other threads:[~2019-01-24  9:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 12:54 parallelism in the module-level, generated GNUmakefile's Laszlo Ersek
2019-01-23 16:36 ` Gao, Liming
2019-01-23 22:07   ` Laszlo Ersek
2019-01-24  9:57     ` Gao, Liming [this message]
2019-01-24 11:40       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3C14D1@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox