Re: [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5

["Gao, Liming" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>Sent: Friday, January 25, 2019 4:12 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>;
>Wang, Jian J <jian.j.wang@intel.com>; Ard Biesheuvel
><ard.biesheuvel@linaro.org>
>Subject: [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone
>MM modules for EBC or XCODE5
>
>The newly added standalone MM versions of the FTW and variable runtime
>drivers were included in MdeModulePkg.dsc to get test coverage when
>building the package from its own .dsc, but the resulting modules are
>non-functional since they incorporate some dummy libraries.
>
>Dandan reports that these modules don't build cleanly when using the
>EBC or XCODE5 compilers, so given the above, let's just ignore them
>in this case.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>---
> MdeModulePkg/MdeModulePkg.dsc | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/MdeModulePkg/MdeModulePkg.dsc
>b/MdeModulePkg/MdeModulePkg.dsc
>index 93eaf4b404a1..55eca4d74c04 100644
>--- a/MdeModulePkg/MdeModulePkg.dsc
>+++ b/MdeModulePkg/MdeModulePkg.dsc
>@@ -426,9 +426,6 @@ [Components]
>   MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
>   MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
>
>-
>MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal
>oneMm.inf
>-
>MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
>-
> [Components.IA32, Components.X64, Components.AARCH64]
>   MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
>   MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf
>@@ -442,6 +439,11 @@ [Components.IA32, Components.X64,
>Components.ARM, Components.AARCH64]
>
>NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32G
>uidedSectionExtractLib.inf
>   }
>
>+!if $(TOOL_CHAIN_TAG) != "XCODE5"
>+
>MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal
>oneMm.inf
>+
>MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
>+!endif
>+
> [Components.IA32, Components.X64, Components.Ebc]
>
>MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeD
>xe.inf
>
>--
>2.17.1