From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D3CE211BA45E for ; Fri, 25 Jan 2019 01:26:36 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2019 01:26:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,520,1539673200"; d="scan'208";a="128482190" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 25 Jan 2019 01:26:36 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 25 Jan 2019 01:26:36 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 25 Jan 2019 01:26:36 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0415.000; Fri, 25 Jan 2019 17:26:34 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "Bi, Dandan" , "Wang, Jian J" Thread-Topic: [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5 Thread-Index: AQHUtIXVKecAbIo0AESr2quJ1H7SOqW/txBA Date: Fri, 25 Jan 2019 09:26:33 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3D0761@SHSMSX104.ccr.corp.intel.com> References: <20190125081205.2967-1-ard.biesheuvel@linaro.org> In-Reply-To: <20190125081205.2967-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 09:26:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >Sent: Friday, January 25, 2019 4:12 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Bi, Dandan ; >Wang, Jian J ; Ard Biesheuvel > >Subject: [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone >MM modules for EBC or XCODE5 > >The newly added standalone MM versions of the FTW and variable runtime >drivers were included in MdeModulePkg.dsc to get test coverage when >building the package from its own .dsc, but the resulting modules are >non-functional since they incorporate some dummy libraries. > >Dandan reports that these modules don't build cleanly when using the >EBC or XCODE5 compilers, so given the above, let's just ignore them >in this case. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Ard Biesheuvel >--- > MdeModulePkg/MdeModulePkg.dsc | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/MdeModulePkg/MdeModulePkg.dsc >b/MdeModulePkg/MdeModulePkg.dsc >index 93eaf4b404a1..55eca4d74c04 100644 >--- a/MdeModulePkg/MdeModulePkg.dsc >+++ b/MdeModulePkg/MdeModulePkg.dsc >@@ -426,9 +426,6 @@ [Components] > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > >- >MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal >oneMm.inf >- >MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf >- > [Components.IA32, Components.X64, Components.AARCH64] > MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf >@@ -442,6 +439,11 @@ [Components.IA32, Components.X64, >Components.ARM, Components.AARCH64] > >NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32G >uidedSectionExtractLib.inf > } > >+!if $(TOOL_CHAIN_TAG) !=3D "XCODE5" >+ >MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal >oneMm.inf >+ >MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf >+!endif >+ > [Components.IA32, Components.X64, Components.Ebc] > >MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeD >xe.inf > >-- >2.17.1