From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 41DA120971733 for ; Mon, 28 Jan 2019 19:10:10 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2019 19:10:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,535,1539673200"; d="scan'208";a="138691242" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 28 Jan 2019 19:10:09 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 28 Jan 2019 19:10:09 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 28 Jan 2019 19:10:09 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.253]) with mapi id 14.03.0415.000; Tue, 29 Jan 2019 11:10:06 +0800 From: "Gao, Liming" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , Leif Lindholm , Laszlo Ersek , "Wang, Jian J" , "Wu, Hao A" , "Zeng, Star" , "Ni, Ray" , "Carsey, Jaben" Thread-Topic: [PATCH v4 0/7] Introduce two public functions and remove internal ones Thread-Index: AQHUnCpEn1nuyxEXN0KpJzxpstVpGaXFx84g Date: Tue, 29 Jan 2019 03:10:06 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3D1B6F@SHSMSX104.ccr.corp.intel.com> References: <20181225081717.2776-1-shenglei.zhang@intel.com> In-Reply-To: <20181225081717.2776-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDM3N2U2YTItNmU3ZS00NTE4LWJjMDctY2ViOWM3NDdhNGE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUWN3cVRETmF4anYyOHRsR25SRXpiS1FtVWNCZ1N0V1hQWmNBV3JVWkJrNklpQlErZ2hYUUx3b2Y4M0VnVE91eiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4 0/7] Introduce two public functions and remove internal ones X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 03:10:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao for this patch set. > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, December 25, 2018 4:17 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming ; Leif Lindholm ; > Laszlo Ersek ; Wang, Jian J ; W= u, Hao A ; Zeng, Star > ; Ni, Ruiyu ; Carsey, Jaben > Subject: [PATCH v4 0/7] Introduce two public functions and remove interna= l ones >=20 > Introduce public functions CharToUpper and AsciiToUpper. > Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToU= pper. >=20 > v2: Update the title and commit message of 1/3. >=20 > v3: 1.Add a patch to remove AsciiToUpper in EdbSupportString.c. > 2.Revert the changes in Basetools. >=20 > v4: 1.Add1/7: Change function names in EdbSupportString.c. > 2.Update the title of 4/7. > 3.Add 5/7: Use BaseLib api AsciiToUpper in DxeHttpLib.c. > 4.Add 6/7: Use BaseLib api CharToUpper in ShellManParser.c. > 5.Add 7/7: Use BaseLib api CharToUpper in UefiShellLib.c. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Leif Lindholm > Cc: Laszlo Ersek > Cc: Jian J Wang > Cc: Hao Wu > Cc: Star Zeng > Cc: Ruiyu Ni > Cc: Jaben Carsey > Shenglei Zhang (7): > MdeModulePkg/EbcDebugger: Change function names > MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly > MdePkg/BaseLib: Remove InternalCharToUpper and > InternalBaseLibAsciiToUpper > MdeModulePkg/EbcDebugger: Use BaseLib apis AsciiToUpper and > CharToUpper > MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiToUpper > ShellPkg/Shell: Use BaseLib api CharToUpper > ShellPkg/UefiShellLib: Use BaseLib api CharToUpper >=20 > MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 23 +--------- > .../EbcDxe/EbcDebugger/EdbSupportString.c | 39 ++--------------- > MdePkg/Include/Library/BaseLib.h | 40 ++++++++++++++++++ > MdePkg/Library/BaseLib/BaseLibInternals.h | 42 ------------------- > MdePkg/Library/BaseLib/SafeString.c | 8 ++-- > MdePkg/Library/BaseLib/String.c | 16 +++---- > ShellPkg/Application/Shell/ShellManParser.c | 23 +--------- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 31 +------------- > 8 files changed, 60 insertions(+), 162 deletions(-) >=20 > -- > 2.18.0.windows.1