From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 74365211B5A44 for ; Tue, 29 Jan 2019 17:52:45 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 17:52:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,539,1539673200"; d="scan'208";a="142557753" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 29 Jan 2019 17:52:44 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 29 Jan 2019 17:52:43 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.109]) with mapi id 14.03.0415.000; Wed, 30 Jan 2019 09:52:42 +0800 From: "Gao, Liming" To: Laszlo Ersek , "Feng, Bob C" CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set Thread-Index: AQHUt3fKEzUl5vwzQ02/Ad2MmxoUb6XFshmAgAFbmiA= Date: Wed, 30 Jan 2019 01:52:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3D21FD@SHSMSX104.ccr.corp.intel.com> References: <20190129020610.14300-1-bob.c.feng@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjcwYmNjM2ItZGIzOC00YjY3LThiMjctZWQ0NzE2NDI5MzEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFBFUXV6aUd0VlNIWW5Ea2xXd2J0UlNWaFJKbEFsUVdtYk5pK3d6Y3hqckw2UDhzdG5VWkNWWW14OXNuZ0ZxZyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v2 00/33] BaseTools python3 migration patch set X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 01:52:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo: I agree your proposal. Push this patch set first if no other comments, the= n continue to do minor bug fix.=20 =20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo Ersek > Sent: Tuesday, January 29, 2019 9:07 PM > To: Feng, Bob C > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch se= t >=20 > Hi Bob, >=20 > On 01/29/19 03:05, Feng, Bob C wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D55 > > > > V2: > > The python files under CParser4 folder of ECC/Eot tool > > are generated by antlr4 and forpython3 usage. > > They have python3 specific syntax, for example > > the data type declaration for the arguments of a function. That > > is not compitable with python2. this patch is to remove these syntax. > > > > The version2 patch set is commit to https://github.com/BobCF/edk2.git > > branch py3basetools_v2 >=20 > (reusing the "test plan" from my email at > :) >=20 > I ran the following tests, at commit 6edb6bd9f182 ("BaseTools: Eot tool > Python3 adaption", 2019-01-29). Each test was performed in a clean tree > (after running "git clean -ffdx") and clean environment (I re-sourced > "edksetup.sh" for each test in separation). In addition, the base tools > were rebuilt (again from a clean tree) for each test, with the following > command [1]: >=20 > nice make -C "$EDK_TOOLS_PATH" -j $(getconf _NPROCESSORS_ONLN) >=20 > (a) On my RHEL7.5 Workstation laptop, I have both the system-level > python packages installed (python-2.7.5-69.el7_5.x86_64), and the extra > python-3.4 stuff from EPEL-7 (python34-3.4.9-1.el7.x86_64). >=20 > (a1) Didn't set either PYTHON3_ENABLE or PYTHON_COMMAND. The build > utility picked >=20 > PYTHON_COMMAND =3D /usr/bin/python3.4 >=20 > and I successfully built OvmfPkg for IA32, IA32X64, and X64; also > ArmVirtQemu for AARCH64. The built firmware images passed a smoke test > too. >=20 > (a2) I removed all the python34 packages (and the dependent packages) > from my laptop. Didn't set either of PYTHON3_ENABLE and PYTHON_COMMAND. > (This is the configuration what a "normal" RHEL7 environment would > provide.) The "build" utility didn't print any PYTHON_COMMAND setting, > but the same fw platform builds as in (a1) completed fine. The smoke > tests passed again as well. >=20 > (b) RHEL-8 virtual machine, with "/usr/bin/python3.6" from > python36-3.6.6-18.el8.x86_64, and "/usr/libexec/platform-python" from > platform-python-3.6.8-1.el8.x86_64. >=20 > (b1) Didn't set either PYTHON3_ENABLE or PYTHON_COMMAND. The build > utility picked >=20 > PYTHON_COMMAND =3D /usr/bin/python3.6 >=20 > and I successfully built OvmfPkg for IA32, IA32X64, and X64. (I don't > have a cross-compiler installed in this environment yet, nor a RHEL8 > aarch64 KVM guest, so I couldn't test ArmVirtQemu for now). >=20 > (b2) I set PYTHON_COMMAND to "/usr/libexec/platform-python". Didn't set > PYTHON3_ENABLE. The same builds as in (b1) succeeded. >=20 >=20 > For the series: >=20 > Tested-by: Laszlo Ersek >=20 > Given that the testing is quite time consuming, I suggest that we push > v2 (assuming reviewers don't find critical issues), and address small > issues incrementally. >=20 > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel